Skip to content
This repository was archived by the owner on Feb 24, 2026. It is now read-only.

chore: small refactor/cleanup in KeyFactory#942

Merged
triplequark merged 3 commits intogoogleapis:multi-dbfrom
kolea2:key-factory-multi-db
Dec 20, 2022
Merged

chore: small refactor/cleanup in KeyFactory#942
triplequark merged 3 commits intogoogleapis:multi-dbfrom
kolea2:key-factory-multi-db

Conversation

@kolea2
Copy link
Copy Markdown
Contributor

@kolea2 kolea2 commented Dec 19, 2022

No description provided.

@kolea2 kolea2 requested review from a team December 19, 2022 21:19
@product-auto-label product-auto-label Bot added size: xs Pull request size is extra small. api: datastore Issues related to the googleapis/java-datastore API. labels Dec 19, 2022
@kolea2 kolea2 closed this Dec 19, 2022
@kolea2 kolea2 reopened this Dec 19, 2022
@kolea2 kolea2 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 20, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 20, 2022
@kolea2 kolea2 added the owlbot:run Add this label to trigger the Owlbot post processor. label Dec 20, 2022
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Dec 20, 2022
@triplequark triplequark merged commit 0dbfe2a into googleapis:multi-db Dec 20, 2022
kolea2 added a commit to kolea2/java-datastore that referenced this pull request May 24, 2023
* chore: small refactor/cleanup in KeyFactory

* fix
gcf-merge-on-green Bot pushed a commit that referenced this pull request Jun 8, 2023
This PR consists of cherry picks from the https://togithub.com/googleapis/java-datastore/tree/multi-db branch. They include:

#928 
#940 
#942 

This also enables parameterized testing for ITDatastoreTest.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: datastore Issues related to the googleapis/java-datastore API. size: xs Pull request size is extra small.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants