feat: add x-goog-request-params to header#940
feat: add x-goog-request-params to header#940triplequark merged 1 commit intogoogleapis:multi-dbfrom
Conversation
viacheslav-rostovtsev
left a comment
There was a problem hiding this comment.
LGTM, but check the comment
| @VisibleForTesting static final String API_FORMAT_VERSION_HEADER = "X-Goog-Api-Format-Version"; | ||
| private static final String API_FORMAT_VERSION = "2"; | ||
|
|
||
| @VisibleForTesting static final String X_GOOG_REQUEST_PARAMS_HEADER = "x-goog-request-params"; |
There was a problem hiding this comment.
This makes me think that we should expose this key as public in gax-java in the future, we have the same key defined here
There was a problem hiding this comment.
@blakeli0 makes sense! This module doesn't depend on gax, but let me know if you'd like any similar changes here.
|
I know we probably only need |
@blakeli0 this is an interesting idea - I will file an issue to look into this as a refactor for the future |
This PR consists of cherry picks from the https://togithub.com/googleapis/java-datastore/tree/multi-db branch. They include: #928 #940 #942 This also enables parameterized testing for ITDatastoreTest.
No description provided.