This repository was archived by the owner on Feb 24, 2026. It is now read-only.
refactor: making query class generic #875
Merged
kolea2 merged 3 commits intogoogleapis:mainfrom Oct 14, 2022
Merged
Conversation
…ns to an internal RecordQuery interface
|
🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use -- conventional-commit-lint bot |
product-auto-label
Bot
added
the
api: datastore
jainsahab
changed the title
kolea2
changed the title
kolea2
approved these changes
Oct 13, 2022
Contributor
kolea2
left a comment
kolea2
left a comment
There was a problem hiding this comment.
lgtm with one outstanding question
jainsahab
added
the
owlbot:run
gcf-owl-bot
Bot
removed
the
owlbot:run
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change decouples Query.java from the concerns related to handling entity records. It is required as the definition of a Query is changed now and it is not just limited to the the fact that every query returns entity records, With the introduction of count feature and aggregation query, we will have queries returning aggregation results.
Note: This PR is intended to trim down the changes done as part of #823.