Skip to content
This repository was archived by the owner on Feb 24, 2026. It is now read-only.

feat: Count API #823

Merged
kolea2 merged 67 commits intogoogleapis:mainfrom
jainsahab:count_feature
Oct 17, 2022
Merged

feat: Count API #823
kolea2 merged 67 commits intogoogleapis:mainfrom
jainsahab:count_feature

Conversation

@jainsahab
Copy link
Copy Markdown
Contributor

@jainsahab jainsahab commented Sep 14, 2022 •
edited
Loading

Add support for querying the Datastore backend to just get the count (i.e. the size of the result set) for a query, instead of getting the entire result set.

@jainsahab
Add method in Datastore client to invoke rpc for aggregation query
ce4c149
@jainsahab
Creating count aggregation and using it to populate Aggregation proto
100115f
@jainsahab
Moving aggregation builder method to root level aggregation class
c1956d8
@jainsahab
Introducing RecordQuery to represent queries which returns entity rec…
493edfa 
…ords when executed
@jainsahab
Updating gitignore with patch extension
9c7c4ba
@jainsahab
Setting up structure of Aggregation query and its builder
cf49a37
@jainsahab
Introducing ProtoPreparer to populate the request protos
78fd6c9
@jainsahab
Delegating responsibility of preparing query proto to QueryPreparer
2ae957a
@jainsahab
Populating aggregation query with nested structured query
14ac55f
@jainsahab
Delegating responsibility of preparing query proto in GqlQuery to Que…
3ff182f 
…ryPreparer
@jainsahab
Removing RecordQuery from the query hierarchy and making it a standal…
7de95e6 
…one interface for now
@jainsahab
Populating aggregation query with nested gql query
d62964f
@jainsahab
Removing deprecation warning by using assertThrows instead of Expecte…
1f5b1a4 
…dException rule
@jainsahab
Making DatastoreRpc call aggregation query method on client
b69b166
@jainsahab
Creating response transformer to transform aggregation query response…
9589f5c 
… into domain objects
@jainsahab
Implementing aggregation query executor to execute AggergationQuery
2103b80
@jainsahab
Adding missing assertion statements
775c341
@jainsahab
Creating RetryExecutor to inject it as a dependency in other components
8872a55
@jainsahab
Making RetryExecutor accept RetrySettings when creating it
1dfafb7
@jainsahab
Revert "Making RetryExecutor accept RetrySettings when creating it"
f6bf0ce 
This reverts commit 1dfafb7.
@jainsahab
Revert "Creating RetryExecutor to inject it as a dependency in other …
deb63bf 
…components"

This reverts commit 8872a55.
@jainsahab
Introducing RetryAndTraceDatastoreRpcDecorator to have retry and trac…
428e9e3 
…eability logic on top of another DatastoreRpc
@jainsahab
Extracting out the responsibility of preparing ReadOption in it's own…
c86913e 
… ProtoPreparer
@jainsahab
Making QueryExecutor to execute query with provided ReadOptions
b235935
@jainsahab
Exposing readTime to the user
f1c3379
@jainsahab jainsahab requested review from a team September 14, 2022 14:16
@product-auto-label product-auto-label Bot added size: xl Pull request size is extra large. api: datastore Issues related to the googleapis/java-datastore API. labels Sep 14, 2022
@jainsahab jainsahab mentioned this pull request Oct 10, 2022
Merged
@jainsahab jainsahab added the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 10, 2022
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 10, 2022
@jainsahab jainsahab added the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 12, 2022
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 12, 2022
This was referenced Oct 13, 2022
Merged
Merged
gcf-merge-on-green Bot pushed a commit that referenced this pull request Oct 14, 2022
@jainsahab
refactor: Extracting out Proto preparation logic to encourage reusabi…
4641306 
…lity (#876)

This change introduces a component called ProtoPreparer which will be used to populate the protos from the domain objects. In the upcoming count aggregation feature, aggregation query will be acting upon StructuredQuery and GqlQuery and hence need to populate the protos of those queries **again**.  For that reason _ProtoPreparer_ component will have the responsibility to populate the protos and be reused in multiple usecases.

_Note: This PR is intended to trim down the changes done as part of #823 ._
@jainsahab jainsahab added the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 14, 2022
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 14, 2022
kolea2
kolea2 suggested changes Oct 14, 2022
View reviewed changes
Comment thread google-cloud-datastore/src/main/java/com/google/cloud/datastore/AggregationResults.java Outdated
Comment thread ...d-datastore/src/main/java/com/google/cloud/datastore/RetryAndTraceDatastoreRpcDecorator.java
Comment thread google-cloud-datastore/src/main/java/com/google/cloud/datastore/StructuredQuery.java
Comment thread google-cloud-datastore/src/main/java/com/google/cloud/datastore/TransactionImpl.java
Comment thread .../java/com/google/cloud/datastore/execution/response/AggregationQueryResponseTransformer.java
Comment thread google-cloud-datastore/src/test/java/com/google/cloud/datastore/ProtoTestData.java Outdated
Comment thread ...tastore/src/test/java/com/google/cloud/datastore/execution/AggregationQueryExecutorTest.java Outdated
Comment thread google-cloud-datastore/src/test/java/com/google/cloud/datastore/DatastoreTest.java Outdated
@kolea2 kolea2 added the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 17, 2022
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 17, 2022
@kolea2 kolea2 added the automerge Merge the pull request once unit tests and other checks pass. label Oct 17, 2022
@kolea2 kolea2 merged commit 8c22e61 into googleapis:main Oct 17, 2022
@gcf-merge-on-green gcf-merge-on-green Bot removed the automerge Merge the pull request once unit tests and other checks pass. label Oct 17, 2022
@release-please release-please Bot mentioned this pull request Oct 17, 2022
Merged
@gforgurups gforgurups self-requested a review October 31, 2022 09:02
@jainsahab jainsahab mentioned this pull request Apr 4, 2023
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@gforgurups gforgurups Awaiting requested review from gforgurups

2 more reviewers

@vishwarajanand vishwarajanand vishwarajanand left review comments

@kolea2 kolea2 kolea2 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: datastore Issues related to the googleapis/java-datastore API. size: xl Pull request size is extra large.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jainsahab @vishwarajanand @kolea2 @gforgurups