Skip to content
This repository was archived by the owner on Feb 24, 2026. It is now read-only.

samples: Add example snippet for snapshot reads#809

Merged
jainsahab merged 3 commits intogoogleapis:mainfrom
jlara310:snapshot-reads
Nov 3, 2022
Merged

samples: Add example snippet for snapshot reads#809
jainsahab merged 3 commits intogoogleapis:mainfrom
jlara310:snapshot-reads

Conversation

@jlara310
Copy link
Copy Markdown
Contributor

@jlara310 jlara310 commented Aug 4, 2022

Add a snippet that shows how to set a readTime in entity retrievals.

Fixes #808 ☕️

If you write sample code, please follow the samples format.

@conventional-commit-lint-gcf
Copy link
Copy Markdown

conventional-commit-lint-gcf Bot commented Aug 4, 2022 •
edited
Loading

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@snippet-bot
Copy link
Copy Markdown

snippet-bot Bot commented Aug 4, 2022 •
edited
Loading

Here is the summary of changes.

You are about to add 1 region tag.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@product-auto-label product-auto-label Bot added size: s Pull request size is small. api: datastore Issues related to the googleapis/java-datastore API. samples Issues that are directly related to samples. labels Aug 4, 2022
@jlara310
Copy link
Copy Markdown
Contributor Author

jlara310 commented Aug 4, 2022

@yixiaoshen , please review, too.

@jlara310 jlara310 changed the title samples: Add example snippet for snapshot reads test: Add example snippet for snapshot reads Aug 4, 2022
yixiaoshen
yixiaoshen approved these changes Aug 4, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@yixiaoshen yixiaoshen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

kolea2
kolea2 approved these changes Aug 25, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@kolea2 kolea2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm with one suggestion. Thanks for adding this!

Comment thread samples/snippets/src/test/java/com/google/datastore/snippets/ConceptsTest.java Outdated
@kolea2 kolea2 changed the title test: Add example snippet for snapshot reads samples: Add example snippet for snapshot reads Aug 25, 2022
@jainsahab jainsahab added the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 20, 2022
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 20, 2022
@gcf-owl-bot gcf-owl-bot Bot requested review from a team October 20, 2022 14:13
@jainsahab jainsahab added the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 23, 2022
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 23, 2022
@jlara310 jlara310 force-pushed the snapshot-reads branch 2 times, most recently from bae93fa to 31fe0d0 Compare November 2, 2022 21:20
@jainsahab jainsahab added the owlbot:run Add this label to trigger the Owlbot post processor. label Nov 3, 2022
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Nov 3, 2022
jainsahab
jainsahab approved these changes Nov 3, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@jainsahab jainsahab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jainsahab jainsahab merged commit eb1e714 into googleapis:main Nov 3, 2022
@jlara310 jlara310 deleted the snapshot-reads branch November 3, 2022 18:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

3 more reviewers

@jainsahab jainsahab jainsahab approved these changes

@yixiaoshen yixiaoshen yixiaoshen approved these changes

@kolea2 kolea2 kolea2 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@Neenu1995 Neenu1995

Labels

api: datastore Issues related to the googleapis/java-datastore API. samples Issues that are directly related to samples. size: s Pull request size is small.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add documentation snippets for snapshot reads

5 participants

@jlara310 @jainsahab @yixiaoshen @kolea2 @Neenu1995