Skip to content
This repository was archived by the owner on Feb 24, 2026. It is now read-only.

samples: Add samples for sum and avg aggregations#1101

Merged
kolea2 merged 7 commits intogoogleapis:mainfrom
jainsahab:sum_and_avg_samples
Aug 28, 2023
Merged

samples: Add samples for sum and avg aggregations#1101
kolea2 merged 7 commits intogoogleapis:mainfrom
jainsahab:sum_and_avg_samples

Conversation

@jainsahab
Copy link
Copy Markdown
Contributor

@jainsahab jainsahab commented Jun 6, 2023

This PR contains the samples for SUM and AVG aggregations.

blocked on #1067

@jainsahab jainsahab added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Jun 6, 2023
@jainsahab jainsahab requested review from a team June 6, 2023 06:36
@snippet-bot
Copy link
Copy Markdown

snippet-bot Bot commented Jun 6, 2023 •
edited
Loading

Here is the summary of changes.

You are about to add 10 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@product-auto-label product-auto-label Bot added size: l Pull request size is large. api: datastore Issues related to the googleapis/java-datastore API. samples Issues that are directly related to samples. labels Jun 6, 2023
@generated-files-bot
Copy link
Copy Markdown

generated-files-bot Bot commented Aug 22, 2023

Warning: This pull request is touching the following templated files:

  • samples/snapshot/pom.xml

@kolea2 kolea2 removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Aug 23, 2023
kolea2
kolea2 reviewed Aug 23, 2023
View reviewed changes
Comment thread samples/snapshot/pom.xml Outdated
@kolea2
Copy link
Copy Markdown
Contributor

kolea2 commented Aug 28, 2023

@bourgeoisor, can you PTAL?

@bhshkh
Copy link
Copy Markdown

bhshkh commented Aug 28, 2023

Nit good to have: newline at end of all the files

@bhshkh bhshkh self-requested a review August 28, 2023 18:12
@kolea2 kolea2 added the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 28, 2023
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 28, 2023
@kolea2 kolea2 added automerge Merge the pull request once unit tests and other checks pass. owlbot:run Add this label to trigger the Owlbot post processor. labels Aug 28, 2023
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 28, 2023
@kolea2 kolea2 removed the automerge Merge the pull request once unit tests and other checks pass. label Aug 28, 2023
@kolea2 kolea2 merged commit b16c0a7 into googleapis:main Aug 28, 2023
@kolea2
Copy link
Copy Markdown
Contributor

kolea2 commented Aug 28, 2023

Nit good to have: newline at end of all the files

will follow up in a separate PR, thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@bhshkh bhshkh bhshkh approved these changes

@kolea2 kolea2 kolea2 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@bourgeoisor bourgeoisor

Labels

api: datastore Issues related to the googleapis/java-datastore API. samples Issues that are directly related to samples. size: l Pull request size is large.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jainsahab @kolea2 @bhshkh @bourgeoisor