Skip to content
This repository was archived by the owner on Feb 24, 2026. It is now read-only.

test(fix): testing the serializability behaviour without relying on the underlying concurrency #1079

Merged
gcf-merge-on-green[bot] merged 5 commits intogoogleapis:mainfrom
jainsahab:gh_497
May 19, 2023
Merged

test(fix): testing the serializability behaviour without relying on the underlying concurrency #1079
gcf-merge-on-green[bot] merged 5 commits intogoogleapis:mainfrom
jainsahab:gh_497

Conversation

@jainsahab
Copy link
Copy Markdown
Contributor

@jainsahab jainsahab commented May 17, 2023

fix #497

Since we are testing the behaviour (i.e. if two transactions conflict with each other, the database guarantees that only one can commit successfully at a time) now, both of the tests are now agnostic of underlying concurrency mechanism. This makes sure that both of the tests continue to pass in any gcloud project .

…underlying concurrency implementation details
@jainsahab jainsahab requested review from a team May 17, 2023 08:04
@product-auto-label product-auto-label Bot added size: m Pull request size is medium. api: datastore Issues related to the googleapis/java-datastore API. labels May 17, 2023
@kolea2 kolea2 changed the title fix: testing the serializability behaviour instead of relying on the underlying concurrency test(fix): testing the serializability behaviour instead of relying on the underlying concurrency May 18, 2023
@jainsahab jainsahab changed the title test(fix): testing the serializability behaviour instead of relying on the underlying concurrency test(fix): testing the serializability behaviour without relying on the underlying concurrency May 19, 2023
@jainsahab jainsahab added automerge Merge the pull request once unit tests and other checks pass. owlbot:run Add this label to trigger the Owlbot post processor. labels May 19, 2023
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label May 19, 2023
@gcf-owl-bot gcf-owl-bot Bot requested a review from a team May 19, 2023 05:35
@gcf-merge-on-green gcf-merge-on-green Bot merged commit 6f03fab into googleapis:main May 19, 2023
@gcf-merge-on-green gcf-merge-on-green Bot removed the automerge Merge the pull request once unit tests and other checks pass. label May 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: datastore Issues related to the googleapis/java-datastore API. size: m Pull request size is medium.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

datastore.it.ITDatastoreTest: testTransactionWithRead and testTransactionWithQuery fail if the test DB type is Firestore in Datastore mode

2 participants