Skip to content
This repository was archived by the owner on Sep 16, 2023. It is now read-only.

chore: Generated snippets should not be owned by samples reviewers (#1575)#784

Merged
averikitsch merged 1 commit intomainfrom
owl-bot-update-lock-8175681a918181d306d9c370d3262f16b4c724cc73d74111b7d42fc985ca7f93
Sep 14, 2022
Merged

chore: Generated snippets should not be owned by samples reviewers (#1575)#784
averikitsch merged 1 commit intomainfrom
owl-bot-update-lock-8175681a918181d306d9c370d3262f16b4c724cc73d74111b7d42fc985ca7f93

Conversation

@gcf-owl-bot
Copy link
Copy Markdown
Contributor

@gcf-owl-bot gcf-owl-bot Bot commented Sep 9, 2022

Source-Link: googleapis/synthtool@2e9ac19
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:8175681a918181d306d9c370d3262f16b4c724cc73d74111b7d42fc985ca7f93

@gcf-owl-bot
chore: Generated snippets should not be owned by samples reviewers (#…
3a4743c 
…1575)

Source-Link: googleapis/synthtool@2e9ac19
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:8175681a918181d306d9c370d3262f16b4c724cc73d74111b7d42fc985ca7f93
@gcf-owl-bot gcf-owl-bot Bot requested a review from a team September 9, 2022 21:03
@product-auto-label product-auto-label Bot added the size: xs Pull request size is extra small. label Sep 9, 2022
@trusted-contributions-gcf trusted-contributions-gcf Bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Sep 9, 2022
@product-auto-label product-auto-label Bot added the api: datalabeling Issues related to the googleapis/java-datalabeling API. label Sep 9, 2022
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 9, 2022
@product-auto-label product-auto-label Bot added the samples Issues that are directly related to samples. label Sep 9, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 9, 2022
@meltsufin meltsufin added automerge Merge the pull request once unit tests and other checks pass. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Sep 10, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 10, 2022
@gcf-merge-on-green
Copy link
Copy Markdown

gcf-merge-on-green Bot commented Sep 10, 2022

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.

@gcf-merge-on-green gcf-merge-on-green Bot removed the automerge Merge the pull request once unit tests and other checks pass. label Sep 10, 2022
averikitsch
averikitsch suggested changes Sep 12, 2022
View reviewed changes
Comment thread .github/CODEOWNERS
@@ -8,3 +8,6 @@

# The java-samples-reviewers team is the default owner for samples changes
samples/**/*.java @googleapis/java-samples-reviewers
Copy link
Copy Markdown

@averikitsch averikitsch Sep 12, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

File error, most likely due to java-samples-reviewers not being a contributor to the repo

Copy link
Copy Markdown
Member

@suztomo suztomo Sep 13, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added java-samples-reviewers as Write role

@suztomo suztomo added the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 13, 2022
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 13, 2022
@suztomo suztomo added the automerge Merge the pull request once unit tests and other checks pass. label Sep 13, 2022
@gcf-merge-on-green
Copy link
Copy Markdown

gcf-merge-on-green Bot commented Sep 14, 2022

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.

@gcf-merge-on-green gcf-merge-on-green Bot removed the automerge Merge the pull request once unit tests and other checks pass. label Sep 14, 2022
@averikitsch averikitsch merged commit 5868942 into main Sep 14, 2022
@averikitsch averikitsch deleted the owl-bot-update-lock-8175681a918181d306d9c370d3262f16b4c724cc73d74111b7d42fc985ca7f93 branch September 14, 2022 23:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

3 more reviewers

@suztomo suztomo suztomo left review comments

@averikitsch averikitsch averikitsch approved these changes

@meltsufin meltsufin meltsufin approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@averikitsch averikitsch

Labels

api: datalabeling Issues related to the googleapis/java-datalabeling API. owl-bot-update-lock samples Issues that are directly related to samples. size: xs Pull request size is extra small.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@suztomo @averikitsch @meltsufin @yoshi-kokoro