Skip to content

feat: migrate to google-auth-library for pre-emptive oauth refresh#3228

Merged
gcf-merge-on-green[bot] merged 3 commits intogoogleapis:bigtable-1.xfrom
mutianf:auth
Sep 24, 2021
Merged

feat: migrate to google-auth-library for pre-emptive oauth refresh#3228
gcf-merge-on-green[bot] merged 3 commits intogoogleapis:bigtable-1.xfrom
mutianf:auth

Conversation

@mutianf
Copy link
Copy Markdown
Contributor

@mutianf mutianf commented Sep 23, 2021

Now that auth library bundles pre-emptive refresh, RefreshingOAuth2CredentialsInterceptor can be removed. Also, remove retry on UNAUTHENTICATED

@mutianf mutianf requested a review from a team September 23, 2021 17:27
@product-auto-label product-auto-label bot added the api: bigtable Issues related to the googleapis/java-bigtable-hbase API. label Sep 23, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Sep 23, 2021
@mutianf mutianf added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 23, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 23, 2021
Copy link
Copy Markdown
Collaborator

@igorbernstein2 igorbernstein2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, but please expand your imports

@igorbernstein2 igorbernstein2 changed the title chore: remove refreshing credentials interceptor feat: migrate to google-auth-library for pre-emptive oauth refresh Sep 24, 2021
@mutianf mutianf added automerge Merge the pull request once unit tests and other checks pass. owlbot:run Add this label to trigger the Owlbot post processor. labels Sep 24, 2021
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 24, 2021
@gcf-merge-on-green gcf-merge-on-green bot merged commit 8031a29 into googleapis:bigtable-1.x Sep 24, 2021
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Sep 24, 2021
@mutianf mutianf deleted the auth branch September 24, 2021 18:06
gcf-merge-on-green bot pushed a commit that referenced this pull request Sep 24, 2021
🤖 I have created a release \*beep\* \*boop\*
---
## [1.25.0](https://www.github.com/googleapis/java-bigtable-hbase/compare/v1.24.0...v1.25.0) (2021-09-24)


### Features

* migrate to google-auth-library for pre-emptive oauth refresh ([#3228](https://www.github.com/googleapis/java-bigtable-hbase/issues/3228)) ([8031a29](https://www.github.com/googleapis/java-bigtable-hbase/commit/8031a297aaf7bf612862b21efb70962ad1966633))


### Bug Fixes

* adding validation for snapshot name for hbase import pipeline ([#3203](https://www.github.com/googleapis/java-bigtable-hbase/issues/3203)) ([#3226](https://www.github.com/googleapis/java-bigtable-hbase/issues/3226)) ([38925e8](https://www.github.com/googleapis/java-bigtable-hbase/commit/38925e8517403294b0958296aa5f20da6ba5cc55))


### Documentation

* Add instructions for migrating from HBase to Bigtable (offline via snapshots) ([#3197](https://www.github.com/googleapis/java-bigtable-hbase/issues/3197)) ([17bda3a](https://www.github.com/googleapis/java-bigtable-hbase/commit/17bda3a2d65d8d154b68dc3ff6c538544390ffd5))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
mutianf added a commit to mutianf/java-bigtable-hbase that referenced this pull request Sep 20, 2022
…oogleapis#3228)

Now that auth library bundles [pre-emptive refresh](googleapis/google-auth-library-java#646), RefreshingOAuth2CredentialsInterceptor can be removed. Also, remove retry on UNAUTHENTICATED
mutianf pushed a commit to mutianf/java-bigtable-hbase that referenced this pull request Sep 20, 2022
🤖 I have created a release \*beep\* \*boop\*
---
## [1.25.0](https://www.github.com/googleapis/java-bigtable-hbase/compare/v1.24.0...v1.25.0) (2021-09-24)


### Features

* migrate to google-auth-library for pre-emptive oauth refresh ([googleapis#3228](https://www.github.com/googleapis/java-bigtable-hbase/issues/3228)) ([8031a29](https://www.github.com/googleapis/java-bigtable-hbase/commit/8031a297aaf7bf612862b21efb70962ad1966633))


### Bug Fixes

* adding validation for snapshot name for hbase import pipeline ([googleapis#3203](https://www.github.com/googleapis/java-bigtable-hbase/issues/3203)) ([googleapis#3226](https://www.github.com/googleapis/java-bigtable-hbase/issues/3226)) ([38925e8](https://www.github.com/googleapis/java-bigtable-hbase/commit/38925e8517403294b0958296aa5f20da6ba5cc55))


### Documentation

* Add instructions for migrating from HBase to Bigtable (offline via snapshots) ([googleapis#3197](https://www.github.com/googleapis/java-bigtable-hbase/issues/3197)) ([17bda3a](https://www.github.com/googleapis/java-bigtable-hbase/commit/17bda3a2d65d8d154b68dc3ff6c538544390ffd5))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: bigtable Issues related to the googleapis/java-bigtable-hbase API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants