Skip to content

fix: adding validation for snapshot name for hbase import pipeline (#…#3226

Merged
kolea2 merged 1 commit intogoogleapis:bigtable-1.xfrom
billyjacobson:hbase-snapshot-name-validation
Sep 23, 2021
Merged

fix: adding validation for snapshot name for hbase import pipeline (#…#3226
kolea2 merged 1 commit intogoogleapis:bigtable-1.xfrom
billyjacobson:hbase-snapshot-name-validation

Conversation

@billyjacobson
Copy link
Copy Markdown
Contributor

…3203)

  • fix: adding validation for snapshot name

  • add messages to failures in test

  • Check empty project id and snapshot directory

(cherry picked from commit fa9991a)

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> ☕️

…oogleapis#3203)

* fix: adding validation for snapshot name

* add messages to failures in test

* Check empty project id and snapshot directory

(cherry picked from commit fa9991a)
@billyjacobson billyjacobson requested a review from a team September 22, 2021 18:58
@product-auto-label product-auto-label bot added the api: bigtable Issues related to the googleapis/java-bigtable-hbase API. label Sep 22, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Sep 22, 2021
@eaball35 eaball35 added the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 23, 2021
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 23, 2021
@kolea2 kolea2 merged commit 38925e8 into googleapis:bigtable-1.x Sep 23, 2021
gcf-merge-on-green bot pushed a commit that referenced this pull request Sep 24, 2021
🤖 I have created a release \*beep\* \*boop\*
---
## [1.25.0](https://www.github.com/googleapis/java-bigtable-hbase/compare/v1.24.0...v1.25.0) (2021-09-24)


### Features

* migrate to google-auth-library for pre-emptive oauth refresh ([#3228](https://www.github.com/googleapis/java-bigtable-hbase/issues/3228)) ([8031a29](https://www.github.com/googleapis/java-bigtable-hbase/commit/8031a297aaf7bf612862b21efb70962ad1966633))


### Bug Fixes

* adding validation for snapshot name for hbase import pipeline ([#3203](https://www.github.com/googleapis/java-bigtable-hbase/issues/3203)) ([#3226](https://www.github.com/googleapis/java-bigtable-hbase/issues/3226)) ([38925e8](https://www.github.com/googleapis/java-bigtable-hbase/commit/38925e8517403294b0958296aa5f20da6ba5cc55))


### Documentation

* Add instructions for migrating from HBase to Bigtable (offline via snapshots) ([#3197](https://www.github.com/googleapis/java-bigtable-hbase/issues/3197)) ([17bda3a](https://www.github.com/googleapis/java-bigtable-hbase/commit/17bda3a2d65d8d154b68dc3ff6c538544390ffd5))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
mutianf pushed a commit to mutianf/java-bigtable-hbase that referenced this pull request Sep 20, 2022
…oogleapis#3203) (googleapis#3226)

* fix: adding validation for snapshot name

* add messages to failures in test

* Check empty project id and snapshot directory

(cherry picked from commit fa9991a)
mutianf pushed a commit to mutianf/java-bigtable-hbase that referenced this pull request Sep 20, 2022
🤖 I have created a release \*beep\* \*boop\*
---
## [1.25.0](https://www.github.com/googleapis/java-bigtable-hbase/compare/v1.24.0...v1.25.0) (2021-09-24)


### Features

* migrate to google-auth-library for pre-emptive oauth refresh ([googleapis#3228](https://www.github.com/googleapis/java-bigtable-hbase/issues/3228)) ([8031a29](https://www.github.com/googleapis/java-bigtable-hbase/commit/8031a297aaf7bf612862b21efb70962ad1966633))


### Bug Fixes

* adding validation for snapshot name for hbase import pipeline ([googleapis#3203](https://www.github.com/googleapis/java-bigtable-hbase/issues/3203)) ([googleapis#3226](https://www.github.com/googleapis/java-bigtable-hbase/issues/3226)) ([38925e8](https://www.github.com/googleapis/java-bigtable-hbase/commit/38925e8517403294b0958296aa5f20da6ba5cc55))


### Documentation

* Add instructions for migrating from HBase to Bigtable (offline via snapshots) ([googleapis#3197](https://www.github.com/googleapis/java-bigtable-hbase/issues/3197)) ([17bda3a](https://www.github.com/googleapis/java-bigtable-hbase/commit/17bda3a2d65d8d154b68dc3ff6c538544390ffd5))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: bigtable Issues related to the googleapis/java-bigtable-hbase API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants