Skip to content

chore: stop publishing test artifacts & fix maven-jar-plugin failures on test artifacts#2922

Merged
gcf-merge-on-green[bot] merged 2 commits intogoogleapis:masterfrom
igorbernstein2:fix-install
Apr 14, 2021
Merged

chore: stop publishing test artifacts & fix maven-jar-plugin failures on test artifacts#2922
gcf-merge-on-green[bot] merged 2 commits intogoogleapis:masterfrom
igorbernstein2:fix-install

Conversation

@igorbernstein2
Copy link
Copy Markdown
Collaborator

@igorbernstein2 igorbernstein2 commented Apr 14, 2021

  • This updates all test artifacts to disable release related plugins: deploy, nexus-staging, site, source, javadoc, gpg, & clirr.
  • The integration test modules were failing build because they don't have any prod classes, so maven-jar-plugin would fail because it couldnt find the primary jar. This fixes it by adding placeholder classes
  • Finally this pre-emptively applies changes from fix: release scripts from issuing overlapping phases synthtool#1043

fixes #2880

… on test artifacts

This updates all test artifacts to disable release related plugins: deploy, nexus-staging, site, source, javadoc, gpg, & clirr.
Also the integration test modules were failing build because they don't have any prod classes, so maven-jar-plugin would fail because it couldnt find the primary jar. This fixes it by adding placeholder classes
@igorbernstein2 igorbernstein2 requested review from a team April 14, 2021 17:23
@generated-files-bot
Copy link
Copy Markdown

Warning: This pull request is touching the following templated files:

  • .kokoro/release/snapshot.sh
  • .kokoro/release/stage.sh

@product-auto-label product-auto-label Bot added the api: bigtable Issues related to the googleapis/java-bigtable-hbase API. label Apr 14, 2021
@google-cla google-cla Bot added the cla: yes This human has signed the Contributor License Agreement. label Apr 14, 2021
@igorbernstein2 igorbernstein2 requested a review from kolea2 April 14, 2021 17:24
@igorbernstein2 igorbernstein2 added the automerge Merge the pull request once unit tests and other checks pass. label Apr 14, 2021
@gcf-merge-on-green gcf-merge-on-green Bot merged commit da7183b into googleapis:master Apr 14, 2021
@gcf-merge-on-green gcf-merge-on-green Bot removed the automerge Merge the pull request once unit tests and other checks pass. label Apr 14, 2021
@igorbernstein2 igorbernstein2 deleted the fix-install branch April 14, 2021 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: bigtable Issues related to the googleapis/java-bigtable-hbase API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

stop publishing test artifacts

2 participants