Support Proto/Enum types in test proxy#2671
Merged
mutianf merged 1 commit intogoogleapis:mainfrom Sep 17, 2025
Merged
Conversation
product-auto-label
bot
added
size: l
Also add schemaBundleId to SchemalessProto/Enum types Change-Id: I8878817ea7f194ce9d51939c1aae314304281b52
product-auto-label
bot
added
size: m
jackdingilian
approved these changes
Sep 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces the following changes:
schemaBundleIdin SchemalessProto/Enum types.2.is basically a no-op, as theschema_bundle_idis currently not populated by the server in ExecuteQuery response b/430920742, and SchemalessProto/Enum types are not exposed to the external users. However, this change ensures that once b/430920742 is resolved, the Java client will correctly handle and store theschema_bundle_id, and the test proxy will be able to save it correctly in its own protos.Change-Id: I8878817ea7f194ce9d51939c1aae314304281b52