fix: make sure to propagate the response when throttling is enabled by igorbernstein2 · Pull Request #1908 · googleapis/java-bigtable

igorbernstein2 · 2023-09-12T02:10:09Z

Change-Id: I690c522aebea03a966155d930bff26042d1bb1f1

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
Ensure the tests and linter pass
Code coverage does not decrease (if any source code was changed)
Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> ☕️

If you write sample code, please follow the samples format.

Change-Id: I690c522aebea03a966155d930bff26042d1bb1f1

…oogleapis#1908) Change-Id: I690c522aebea03a966155d930bff26042d1bb1f1 Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly: - [ ] Make sure to open an issue as a [bug/issue](https://togithub.com/googleapis/java-bigtable/issues/new/choose) before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea - [ ] Ensure the tests and linter pass - [ ] Code coverage does not decrease (if any source code was changed) - [ ] Appropriate docs were updated (if necessary) Fixes #<issue_number_goes_here> ☕️ If you write sample code, please follow the [samples format]( https://togithub.com/GoogleCloudPlatform/java-docs-samples/blob/main/SAMPLE_FORMAT.md).

…1908) (#1922) Change-Id: I690c522aebea03a966155d930bff26042d1bb1f1 Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly: - [ ] Make sure to open an issue as a [bug/issue](https://togithub.com/googleapis/java-bigtable/issues/new/choose) before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea - [ ] Ensure the tests and linter pass - [ ] Code coverage does not decrease (if any source code was changed) - [ ] Appropriate docs were updated (if necessary) Fixes #<issue_number_goes_here> ☕️ If you write sample code, please follow the [samples format]( https://togithub.com/GoogleCloudPlatform/java-docs-samples/blob/main/SAMPLE_FORMAT.md). Co-authored-by: Igor Bernstein <[email protected]>

…p/templates/java_library/.kokoro (#1908) build(deps): bump cryptography Bumps [cryptography](https://github.com/pyca/cryptography) from 41.0.3 to 41.0.6. - [Changelog](https://github.com/pyca/cryptography/blob/main/CHANGELOG.rst) - [Commits](pyca/cryptography@41.0.3...41.0.6) --- updated-dependencies: - dependency-name: cryptography dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Source-Link: googleapis/synthtool@ea6f800 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:81f75d962cd28b7ad10740a643b8069b8fa0357cb495b782eef8560bb7a8fd65

…p/templates/java_library/.kokoro (#1908) (#2023) build(deps): bump cryptography Bumps [cryptography](https://github.com/pyca/cryptography) from 41.0.3 to 41.0.6. - [Changelog](https://github.com/pyca/cryptography/blob/main/CHANGELOG.rst) - [Commits](pyca/cryptography@41.0.3...41.0.6) --- updated-dependencies: - dependency-name: cryptography dependency-type: indirect ... Source-Link: googleapis/synthtool@ea6f800 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:81f75d962cd28b7ad10740a643b8069b8fa0357cb495b782eef8560bb7a8fd65 Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

fix: make sure to propagate the response when throttling is enabled

4a0ce74

Change-Id: I690c522aebea03a966155d930bff26042d1bb1f1

igorbernstein2 requested a review from a team September 12, 2023 02:10

product-auto-label bot added size: s Pull request size is small. api: bigtable Issues related to the googleapis/java-bigtable API. labels Sep 12, 2023

rameshdharan approved these changes Sep 12, 2023

View reviewed changes

igorbernstein2 added the automerge Merge the pull request once unit tests and other checks pass. label Sep 12, 2023

gcf-merge-on-green bot merged commit f743187 into main Sep 12, 2023

gcf-merge-on-green bot deleted the missing-response branch September 12, 2023 02:32

gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Sep 12, 2023

release-please bot mentioned this pull request Sep 11, 2023

chore(main): release 2.27.1 #1903

Merged

kolea2 mentioned this pull request Sep 15, 2023

fix: make sure to propagate the response when throttling is enabled (#1908) #1922

Merged

release-please bot mentioned this pull request Sep 15, 2023

chore(2.25.x): release 2.25.2 #1925

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: make sure to propagate the response when throttling is enabled#1908

fix: make sure to propagate the response when throttling is enabled#1908
gcf-merge-on-green[bot] merged 1 commit intomainfrom
missing-response

igorbernstein2 commented Sep 12, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

igorbernstein2 commented Sep 12, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants