-
Notifications
You must be signed in to change notification settings - Fork 106
equals is broken for UpdateAppProfileRequest #1105
Copy link
Copy link
Closed
Labels
api: bigtableIssues related to the googleapis/java-bigtable API.Issues related to the googleapis/java-bigtable API.priority: p2Moderately-important priority. Fix may not be included in next release.Moderately-important priority. Fix may not be included in next release.type: bugError or flaw in code with unintended results or allowing sub-optimal usage patterns.Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Description
Metadata
Metadata
Assignees
Labels
api: bigtableIssues related to the googleapis/java-bigtable API.Issues related to the googleapis/java-bigtable API.priority: p2Moderately-important priority. Fix may not be included in next release.Moderately-important priority. Fix may not be included in next release.type: bugError or flaw in code with unintended results or allowing sub-optimal usage patterns.Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
java-bigtable/google-cloud-bigtable/src/main/java/com/google/cloud/bigtable/admin/v2/models/UpdateAppProfileRequest.java
Line 154 in 0d197a5
The proto comparison must build the proto before comparison. Also, comparing the proto is problematic here since the proto builder mutates when toProto((String projectId) is called