Skip to content

Conversation

@stephaniewang526
Copy link
Contributor

@stephaniewang526 stephaniewang526 commented Apr 21, 2020

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 21, 2020
@codecov
Copy link

codecov bot commented Apr 21, 2020

Codecov Report

Merging #201 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #201   +/-   ##
=========================================
  Coverage     74.58%   74.58%           
  Complexity      344      344           
=========================================
  Files            45       45           
  Lines          2361     2361           
  Branches         82       82           
=========================================
  Hits           1761     1761           
  Misses          562      562           
  Partials         38       38           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 440d85b...faa0287. Read the comment docs.

@stephaniewang526 stephaniewang526 changed the title fix: add file exclusion due to gapic code-gen template bug fix: add temp code replacement hack due to gapic code-gen template bug Apr 21, 2020
Copy link
Contributor

@chingor13 chingor13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should probably be a chore unless you want it to appear in the release notes

@stephaniewang526 stephaniewang526 changed the title fix: add temp code replacement hack due to gapic code-gen template bug chore: add temp code replacement hack due to gapic code-gen template bug Apr 21, 2020
@stephaniewang526 stephaniewang526 merged commit fbdb52a into googleapis:master Apr 22, 2020
shubhwip pushed a commit to shubhwip/java-bigquerystorage that referenced this pull request Oct 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants