Skip to content

Conversation

@stephaniewang526
Copy link
Contributor

No description provided.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 9, 2020
Copy link
Contributor

@chingor13 chingor13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the commit type, this should probably be a build or ci type.

@codecov
Copy link

codecov bot commented Apr 9, 2020

Codecov Report

Merging #163 into master will not change coverage by %.
The diff coverage is 80.64%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #163   +/-   ##
=========================================
  Coverage     74.18%   74.18%           
  Complexity      320      320           
=========================================
  Files            42       42           
  Lines          2227     2227           
  Branches         71       71           
=========================================
  Hits           1652     1652           
  Misses          545      545           
  Partials         30       30           
Impacted Files Coverage Δ Complexity Δ
.../cloud/bigquery/storage/v1alpha2/StreamWriter.java 82.86% <80.64%> (ø) 29.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b2056e5...03aa928. Read the comment docs.

@stephaniewang526 stephaniewang526 changed the title feat: add dependency list completeness check ci: add dependency list completeness check Apr 9, 2020
Copy link
Contributor

@chingor13 chingor13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, last thing, since these functions are only used in one place, let's merge this into the dependencies.sh. If you want to put the now, msg, and println into common.sh that might be a better place than completeness-check.sh which is not used anywhere else.

@stephaniewang526 stephaniewang526 merged commit 462bb6f into googleapis:master Apr 13, 2020
yoshi-automation added a commit that referenced this pull request Apr 13, 2020
* ci: add dependency list completeness check

* update based on comments

* update based on comments

* update based on comments

* update based on comments

* update based on comments

* update based on comments

* update based on comments

* update based on comments

* dump out diff

Source-Author: Stephanie Wang <[email protected]>
Source-Date: Mon Apr 13 18:02:58 2020 -0400
Source-Repo: googleapis/java-bigquerystorage
Source-Sha: 462bb6f
Source-Link: 462bb6f
yoshi-automation added a commit that referenced this pull request Apr 14, 2020
* ci: add dependency list completeness check

* update based on comments

* update based on comments

* update based on comments

* update based on comments

* update based on comments

* update based on comments

* update based on comments

* update based on comments

* dump out diff

Source-Author: Stephanie Wang <[email protected]>
Source-Date: Mon Apr 13 18:02:58 2020 -0400
Source-Repo: googleapis/java-bigquerystorage
Source-Sha: 462bb6f
Source-Link: 462bb6f
yoshi-automation added a commit that referenced this pull request Apr 15, 2020
* ci: add dependency list completeness check

* update based on comments

* update based on comments

* update based on comments

* update based on comments

* update based on comments

* update based on comments

* update based on comments

* update based on comments

* dump out diff

Source-Author: Stephanie Wang <[email protected]>
Source-Date: Mon Apr 13 18:02:58 2020 -0400
Source-Repo: googleapis/java-bigquerystorage
Source-Sha: 462bb6f
Source-Link: 462bb6f
yoshi-automation added a commit that referenced this pull request Apr 15, 2020
* ci: add dependency list completeness check

* update based on comments

* update based on comments

* update based on comments

* update based on comments

* update based on comments

* update based on comments

* update based on comments

* update based on comments

* dump out diff

Source-Author: Stephanie Wang <[email protected]>
Source-Date: Mon Apr 13 18:02:58 2020 -0400
Source-Repo: googleapis/java-bigquerystorage
Source-Sha: 462bb6f
Source-Link: 462bb6f
shubhwip pushed a commit to shubhwip/java-bigquerystorage that referenced this pull request Oct 7, 2023
…onfig to v0.9.2 (googleapis#163)

This PR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [com.google.cloud:google-cloud-shared-config](https://togithub.com/googleapis/java-shared-config) | minor | `0.8.1` -> `0.9.2` |

---

### Release Notes

<details>
<summary>googleapis/java-shared-config</summary>

### [`v0.9.2`](https://togithub.com/googleapis/java-shared-config/blob/master/CHANGELOG.md#&#8203;092-httpswwwgithubcomgoogleapisjava-shared-configcomparev091v092-2020-07-02)

[Compare Source](https://togithub.com/googleapis/java-shared-config/compare/v0.9.1...v0.9.2)

### [`v0.9.1`](https://togithub.com/googleapis/java-shared-config/blob/master/CHANGELOG.md#&#8203;091-httpswwwgithubcomgoogleapisjava-shared-configcomparev090v091-2020-07-01)

[Compare Source](https://togithub.com/googleapis/java-shared-config/compare/v0.9.0...v0.9.1)

### [`v0.9.0`](https://togithub.com/googleapis/java-shared-config/blob/master/CHANGELOG.md#&#8203;090-httpswwwgithubcomgoogleapisjava-shared-configcomparev081v090-2020-06-25)

[Compare Source](https://togithub.com/googleapis/java-shared-config/compare/v0.8.1...v0.9.0)

##### Features

-   add ignore rule for javax annotations to handle error in java11 ([#&#8203;171](https://www.github.com/googleapis/java-shared-config/issues/171)) ([cd635ad](https://www.github.com/googleapis/java-shared-config/commit/cd635ad6e8e5d71ac3a30e7656eb788027f1c370))

##### [0.8.1](https://www.github.com/googleapis/java-shared-config/compare/v0.8.0...v0.8.1) (2020-06-15)

##### Bug Fixes

-   bump flatten plugin version to fix missing version in profile section issue ([#&#8203;159](https://www.github.com/googleapis/java-shared-config/issues/159)) ([5b34939](https://www.github.com/googleapis/java-shared-config/commit/5b349399a590b589718b7049f66c82ee38742372))

</details>

---

### Renovate configuration

:date: **Schedule**: At any time (no schedule defined).

:vertical_traffic_light: **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

:recycle: **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

:no_bell: **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#googleapis/java-storage-nio).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants