Skip to content
This repository was archived by the owner on Mar 23, 2026. It is now read-only.

build: update samples/stylecheck to use java 11 to match new style gu…#3516

Merged
PhongChuong merged 1 commit intomainfrom
samplesStyleJava11
Oct 3, 2024
Merged

build: update samples/stylecheck to use java 11 to match new style gu…#3516
PhongChuong merged 1 commit intomainfrom
samplesStyleJava11

Conversation

@PhongChuong
Copy link
Copy Markdown
Contributor

…ide as indicated in: https://github.com/GoogleCloudPlatform/java-docs-samples/blob/main/SAMPLE_FORMAT.md#java-version

This fixes the samples/stylecheck in PR#3487

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

@product-auto-label product-auto-label Bot added size: xs Pull request size is extra small. api: bigquery Issues related to the googleapis/java-bigquery API. samples Issues that are directly related to samples. labels Oct 3, 2024
@PhongChuong PhongChuong marked this pull request as ready for review October 3, 2024 16:27
@PhongChuong PhongChuong requested review from a team and whuffman36 October 3, 2024 16:27
Copy link
Copy Markdown
Contributor

@whuffman36 whuffman36 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@PhongChuong PhongChuong merged commit dd087e8 into main Oct 3, 2024
@PhongChuong PhongChuong deleted the samplesStyleJava11 branch October 3, 2024 16:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: bigquery Issues related to the googleapis/java-bigquery API. samples Issues that are directly related to samples. size: xs Pull request size is extra small.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants