Skip to content
This repository was archived by the owner on Mar 23, 2026. It is now read-only.

feat: Add Range object to allow reading range value#3236

Merged
PhongChuong merged 9 commits intomainfrom
range
Apr 17, 2024
Merged

feat: Add Range object to allow reading range value#3236
PhongChuong merged 9 commits intomainfrom
range

Conversation

@PhongChuong
Copy link
Copy Markdown
Contributor

@PhongChuong PhongChuong commented Apr 10, 2024 •
edited
Loading

This PR also adds the ability to use Range query parameter

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #3235 ☕️

@PhongChuong
feat: Add Range object to allow reading range value
567da69 
This PR also adds the ability to use Range query parameter
@PhongChuong PhongChuong requested review from a team and chalmerlowe April 10, 2024 15:50
@product-auto-label product-auto-label Bot added size: l Pull request size is large. api: bigquery Issues related to the googleapis/java-bigquery API. labels Apr 10, 2024
@PhongChuong PhongChuong requested review from a team, Linchin, alvarowolfx and shollyman April 10, 2024 15:52
shollyman
shollyman reviewed Apr 11, 2024
View reviewed changes
Comment thread google-cloud-bigquery/src/main/java/com/google/cloud/bigquery/Range.java Outdated
Comment thread google-cloud-bigquery/src/main/java/com/google/cloud/bigquery/Range.java Outdated
shollyman
shollyman approved these changes Apr 17, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@shollyman shollyman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I got caught up misunderstanding the QueryParameterValue mappings until I realized java uses it to provide both value and typing information.

@PhongChuong
Copy link
Copy Markdown
Contributor Author

PhongChuong commented Apr 17, 2024

Thank you for the review.

@PhongChuong PhongChuong merged commit 2c3399d into main Apr 17, 2024
@PhongChuong PhongChuong deleted the range branch April 17, 2024 20:02
@release-please release-please Bot mentioned this pull request Apr 17, 2024
Merged
This was referenced Apr 30, 2024
Closed
Closed
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@chalmerlowe chalmerlowe Awaiting requested review from chalmerlowe

@Linchin Linchin Awaiting requested review from Linchin

@alvarowolfx alvarowolfx Awaiting requested review from alvarowolfx

1 more reviewer

@shollyman shollyman shollyman approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: bigquery Issues related to the googleapis/java-bigquery API. size: l Pull request size is large.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Support reading range value

2 participants

@PhongChuong @shollyman