Skip to content
This repository was archived by the owner on Mar 23, 2026. It is now read-only.

feat: Add new fields to copy job statistics#3205

Merged
PhongChuong merged 3 commits intomainfrom
326318441
Mar 25, 2024
Merged

feat: Add new fields to copy job statistics#3205
PhongChuong merged 3 commits intomainfrom
326318441

Conversation

@PhongChuong
Copy link
Copy Markdown
Contributor

@PhongChuong PhongChuong commented Mar 22, 2024 •
edited
Loading

Specifically, [copiedRows, copiedLogicalBytes] are added to CopyStatistics.

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #3206 ☕️

If you write sample code, please follow the samples format.

@PhongChuong
feat: Add new fields to copy job statistics
210f3b6 
Specifically, [copiedRows, copiedLogicalBytes] are added to CopyStatistics.
@PhongChuong PhongChuong requested review from a team and nayaknishant March 22, 2024 16:38
@product-auto-label product-auto-label Bot added size: m Pull request size is medium. api: bigquery Issues related to the googleapis/java-bigquery API. labels Mar 22, 2024
@PhongChuong PhongChuong requested a review from shollyman March 22, 2024 20:07
@PhongChuong
Copy link
Copy Markdown
Contributor Author

PhongChuong commented Mar 25, 2024

Thanks for the review. Updated with the suggestions.

shollyman
shollyman approved these changes Mar 25, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@shollyman shollyman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for putting this together!

@PhongChuong PhongChuong merged commit 64bdda8 into main Mar 25, 2024
@PhongChuong PhongChuong deleted the 326318441 branch March 25, 2024 19:48
@release-please release-please Bot mentioned this pull request Mar 26, 2024
Merged
This was referenced Apr 30, 2024
Closed
Closed
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@nayaknishant nayaknishant Awaiting requested review from nayaknishant

1 more reviewer

@shollyman shollyman shollyman approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: bigquery Issues related to the googleapis/java-bigquery API. size: m Pull request size is medium.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add support for [copiedRows, copiedLogicalBytes] to CopyStatistics

2 participants

@PhongChuong @shollyman