Skip to content
This repository was archived by the owner on Mar 23, 2026. It is now read-only.

chore: Refactor TableResult using builder pattern#3130

Merged
PhongChuong merged 5 commits intomainfrom
tableResultBuilder
Feb 22, 2024
Merged

chore: Refactor TableResult using builder pattern#3130
PhongChuong merged 5 commits intomainfrom
tableResultBuilder

Conversation

@PhongChuong
Copy link
Copy Markdown
Contributor

@PhongChuong PhongChuong commented Feb 9, 2024 •
edited
Loading

This also removed the redundant EmptyTableResult. These changes are fine as TableResult and EmptyTableResult are internal API only.

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #3129 ☕️

@PhongChuong
chore: Refactor TableResult using builder pattern
5973bea 
This also removed the redundant EmptyTableResult. These changes are fine as TableResult and EmptyTableResult are internal API only.
@PhongChuong PhongChuong requested review from a team and kiraksi February 9, 2024 13:53
@product-auto-label product-auto-label Bot added size: l Pull request size is large. api: bigquery Issues related to the googleapis/java-bigquery API. labels Feb 9, 2024
@PhongChuong PhongChuong requested a review from shollyman February 9, 2024 14:23
shollyman
shollyman approved these changes Feb 14, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@shollyman shollyman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for cleaning this up, nice that it obviates the need for EmptyTableResult as it's own type as well.

LGTMing, but please checkout the comment issue before submit.

Comment thread google-cloud-bigquery/src/main/java/com/google/cloud/bigquery/TableResult.java Outdated
@PhongChuong PhongChuong merged commit 253f6c9 into main Feb 22, 2024
@PhongChuong PhongChuong deleted the tableResultBuilder branch February 22, 2024 15:12
@Harmelodic Harmelodic mentioned this pull request Mar 28, 2024
Closed
@Abacn Abacn mentioned this pull request Apr 30, 2024
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@kiraksi kiraksi Awaiting requested review from kiraksi

1 more reviewer

@shollyman shollyman shollyman approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: bigquery Issues related to the googleapis/java-bigquery API. size: l Pull request size is large.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Refactor TableResult to builder pattern

2 participants

@PhongChuong @shollyman