Skip to content
This repository was archived by the owner on Mar 23, 2026. It is now read-only.

chore: Java 8 unit test to build code in Java 17 and run tests on Java 8 (#1800)#2770

Merged
gcf-merge-on-green[bot] merged 5 commits intomainfrom
owl-bot-update-lock-32851debfefed2b66038e0141f1b5c2103bb59ba80b7475adbc10ef7abab3de7
Jun 22, 2023
Merged

chore: Java 8 unit test to build code in Java 17 and run tests on Java 8 (#1800)#2770
gcf-merge-on-green[bot] merged 5 commits intomainfrom
owl-bot-update-lock-32851debfefed2b66038e0141f1b5c2103bb59ba80b7475adbc10ef7abab3de7

Conversation

@gcf-owl-bot
Copy link
Copy Markdown
Contributor

@gcf-owl-bot gcf-owl-bot Bot commented Jun 22, 2023

Closes #2768

…a 8 (#1800)

* Our Java projects are configured to produce Java 8-compatible bytecode via https://github.com/googleapis/java-shared-config/blob/main/pom.xml#L848. This unit test change ensures this config is applied correctly.

* This change also switches the JDK distribution of GitHub Actions to temurin from zulu.

* For the repositories that mark "dependencies (8)" and "dependencies (11)" as required, they should point to only "dependencies (17)" via `.github/sync-repo-settings.yaml` and repo's Settings tab.
Source-Link: googleapis/synthtool@cbe0100
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:32851debfefed2b66038e0141f1b5c2103bb59ba80b7475adbc10ef7abab3de7
@gcf-owl-bot gcf-owl-bot Bot requested review from a team and alvarowolfx June 22, 2023 15:09
@product-auto-label product-auto-label Bot added the size: s Pull request size is small. label Jun 22, 2023
@trusted-contributions-gcf trusted-contributions-gcf Bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Jun 22, 2023
@product-auto-label product-auto-label Bot added the api: bigquery Issues related to the googleapis/java-bigquery API. label Jun 22, 2023
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jun 22, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 22, 2023
@trusted-contributions-gcf trusted-contributions-gcf Bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Jun 22, 2023
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jun 22, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 22, 2023
@suztomo suztomo added automerge Merge the pull request once unit tests and other checks pass. owlbot:run Add this label to trigger the Owlbot post processor. labels Jun 22, 2023
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jun 22, 2023
@trusted-contributions-gcf trusted-contributions-gcf Bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Jun 22, 2023
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jun 22, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 22, 2023
@suztomo
Copy link
Copy Markdown
Member

suztomo commented Jun 22, 2023

"ci / units (8)" failed:

[INFO] -------------------------------------------------------
[INFO]  T E S T S
[INFO] -------------------------------------------------------
Unrecognized option: --add-opens=java.base/java.nio=ALL-UNNAMED
Error: Could not create the Java Virtual Machine.
Error: A fatal exception has occurred. Program will exit.

This is because google-cloud-bigquery/pom.xml has special profile to provide the argument to JVM when it runs on JDK 17.

<argLine>--add-opens=java.base/java.nio=ALL-UNNAMED</argLine>

Next step: Figure out how to disable the profile for Java 8 test run.

@trusted-contributions-gcf trusted-contributions-gcf Bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Jun 22, 2023
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jun 22, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 22, 2023
@trusted-contributions-gcf trusted-contributions-gcf Bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Jun 22, 2023
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jun 22, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 22, 2023
@gcf-merge-on-green gcf-merge-on-green Bot merged commit 8c6b9e5 into main Jun 22, 2023
@gcf-merge-on-green gcf-merge-on-green Bot deleted the owl-bot-update-lock-32851debfefed2b66038e0141f1b5c2103bb59ba80b7475adbc10ef7abab3de7 branch June 22, 2023 20:46
@gcf-merge-on-green gcf-merge-on-green Bot removed the automerge Merge the pull request once unit tests and other checks pass. label Jun 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: bigquery Issues related to the googleapis/java-bigquery API. owl-bot-update-lock size: s Pull request size is small.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants