This repository was archived by the owner on Mar 23, 2026. It is now read-only.
samples / fixing authorize dataset logic by updating source dataset acl #2189
Merged
gcf-merge-on-green[bot] merged 7 commits intogoogleapis:mainfrom Aug 23, 2022
Merged
Conversation
… of user dataset acl
product-auto-label
Bot
added
size: xs
averikitsch
reviewed
Aug 4, 2022
product-auto-label
Bot
added
size: s
averikitsch
added
kokoro:force-run
gcf-owl-bot
Bot
removed
the
owlbot:run
averikitsch
approved these changes
Aug 8, 2022
yoshi-kokoro
removed
the
kokoro:force-run
Neenu1995
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
Contributor
Author
|
Updated the failing test case for authorized Dataset. |
averikitsch
added
kokoro:force-run
gcf-owl-bot
Bot
removed
the
owlbot:run
yoshi-kokoro
removed
the
kokoro:force-run
averikitsch
added
kokoro:force-run
gcf-owl-bot
Bot
removed
the
owlbot:run
yoshi-kokoro
removed
the
kokoro:force-run
Contributor
Author
|
Hi, seems this is pending review from one of the owners. Is there something I am missing ? |
averikitsch
added
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
|
@googleapis/api-bigquery and @googleapis/yoshi-java PTAL |
gcf-merge-on-green
Bot
removed
the
automerge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes#2188
Fixed the logic for authorizing a bigquery user dataset but updating the source dataset acl with that of the user dataset information.