Skip to content
This repository was archived by the owner on Mar 23, 2026. It is now read-only.

chore: mark native image checks as required#2147

Merged
prash-mi merged 3 commits intomainfrom
require-graal-check
Jul 8, 2022
Merged

chore: mark native image checks as required#2147
prash-mi merged 3 commits intomainfrom
require-graal-check

Conversation

@mpeddada1
Copy link
Copy Markdown
Contributor

@mpeddada1 mpeddada1 commented Jun 29, 2022

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> ☕️

If you write sample code, please follow the samples format.

@mpeddada1 mpeddada1 requested review from a team and gnanda June 29, 2022 14:20
@generated-files-bot
Copy link
Copy Markdown

generated-files-bot Bot commented Jun 29, 2022

Warning: This pull request is touching the following templated files:

  • .github/sync-repo-settings.yaml

@product-auto-label product-auto-label Bot added size: xs Pull request size is extra small. api: bigquery Issues related to the googleapis/java-bigquery API. labels Jun 29, 2022
@mpeddada1 mpeddada1 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 29, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 29, 2022
@mpeddada1 mpeddada1 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 29, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 29, 2022
@mpeddada1
Copy link
Copy Markdown
Contributor Author

mpeddada1 commented Jun 29, 2022

ITNightlyBigqueryTest is being a little flaky. The error looks similar to #2141

@mpeddada1 mpeddada1 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 29, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 29, 2022
@prash-mi
Copy link
Copy Markdown
Contributor

prash-mi commented Jul 5, 2022

@mpeddada1 Yes, there was an issue with the backend b/237507829 which has been resolved, so the related IT should now be fixed. Also, it appears there's some conflict with the README.me file, do you want to sync it and push the updated changes?

@mpeddada1
Copy link
Copy Markdown
Contributor Author

mpeddada1 commented Jul 7, 2022 •
edited
Loading

thank you @prash-mi! All checks are passing now. Could we get another review on this?

@prash-mi prash-mi merged commit ba383c8 into main Jul 8, 2022
@prash-mi prash-mi deleted the require-graal-check branch July 8, 2022 04:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@gnanda gnanda Awaiting requested review from gnanda

1 more reviewer

@prash-mi prash-mi prash-mi approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: bigquery Issues related to the googleapis/java-bigquery API. size: xs Pull request size is extra small.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mpeddada1 @prash-mi @yoshi-kokoro