feat: configure initial sp version#1282
Conversation
|
Warning: This pull request is touching the following templated files:
|
Codecov Report
@@ Coverage Diff @@
## 1.127.12-sp #1282 +/- ##
==============================================
Coverage 80.17% 80.17%
Complexity 1270 1270
==============================================
Files 79 79
Lines 6629 6629
Branches 766 767 +1
==============================================
Hits 5315 5315
Misses 916 916
Partials 398 398 Continue to review full report at Codecov.
|
shollyman
left a comment
There was a problem hiding this comment.
I have no context on this, and I'm unable to infer what "sp" refers to in this case. The use of null for pull request matching seems odd; should it simply be elided?
|
Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot. |
this is related to b/187189809 |
🤖 I have created a release \*beep\* \*boop\* --- ### [1.127.12-sp.1](https://www.github.com/googleapis/java-bigquery/compare/1.127.12...v1.127.12-sp.1) (2021-05-10) ### Features * configure initial sp version ([#1282](https://www.github.com/googleapis/java-bigquery/issues/1282)) ([edd2370](https://www.github.com/googleapis/java-bigquery/commit/edd237049c96e097d7cada0a3260670055eb78e5)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
No description provided.