Skip to content
This repository was archived by the owner on Mar 23, 2026. It is now read-only.

feat: configure initial sp version#1282

Merged
stephaniewang526 merged 1 commit into1.127.12-spfrom
stephaniewang526-patch-1
May 10, 2021
Merged

feat: configure initial sp version#1282
stephaniewang526 merged 1 commit into1.127.12-spfrom
stephaniewang526-patch-1

Conversation

@stephaniewang526
Copy link
Copy Markdown
Contributor

No description provided.

@stephaniewang526 stephaniewang526 requested review from a team and shollyman May 5, 2021 23:07
@product-auto-label product-auto-label Bot added the api: bigquery Issues related to the googleapis/java-bigquery API. label May 5, 2021
@google-cla google-cla Bot added the cla: yes This human has signed the Contributor License Agreement. label May 5, 2021
@generated-files-bot
Copy link
Copy Markdown

Warning: This pull request is touching the following templated files:

  • .github/workflows/ci.yaml

@stephaniewang526 stephaniewang526 added the automerge Merge the pull request once unit tests and other checks pass. label May 5, 2021
@codecov
Copy link
Copy Markdown

codecov Bot commented May 5, 2021

Codecov Report

Merging #1282 (dbba9a8) into 1.127.12-sp (2aae90b) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff               @@
##             1.127.12-sp    #1282   +/-   ##
==============================================
  Coverage          80.17%   80.17%           
  Complexity          1270     1270           
==============================================
  Files                 79       79           
  Lines               6629     6629           
  Branches             766      767    +1     
==============================================
  Hits                5315     5315           
  Misses               916      916           
  Partials             398      398           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2aae90b...dbba9a8. Read the comment docs.

@stephaniewang526 stephaniewang526 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 5, 2021
Copy link
Copy Markdown
Contributor

@shollyman shollyman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no context on this, and I'm unable to infer what "sp" refers to in this case. The use of null for pull request matching seems odd; should it simply be elided?

@gcf-merge-on-green
Copy link
Copy Markdown

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.

@gcf-merge-on-green gcf-merge-on-green Bot removed the automerge Merge the pull request once unit tests and other checks pass. label May 6, 2021
@stephaniewang526
Copy link
Copy Markdown
Contributor Author

I have no context on this, and I'm unable to infer what "sp" refers to in this case. The use of null for pull request matching seems odd; should it simply be elided?

this is related to b/187189809

@stephaniewang526 stephaniewang526 added kokoro:force-run Add this label to force Kokoro to re-run the tests. automerge Merge the pull request once unit tests and other checks pass. kokoro:run Add this label to force Kokoro to re-run the tests. and removed kokoro:force-run Add this label to force Kokoro to re-run the tests. labels May 6, 2021
@chingor13 chingor13 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 10, 2021
@yoshi-kokoro yoshi-kokoro removed kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels May 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: bigquery Issues related to the googleapis/java-bigquery API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants