Skip to content
This repository was archived by the owner on Mar 23, 2026. It is now read-only.
This repository was archived by the owner on Mar 23, 2026. It is now read-only.

Unchecked NPE in ConnectionImpl:dryRun #2895

Closed
#2899
Closed
Unchecked NPE in ConnectionImpl:dryRun#2895
#2899
Assignees
obada-ab
Labels
api: bigqueryIssues related to the googleapis/java-bigquery API.priority: p2Moderately-important priority. Fix may not be included in next release.type: bugError or flaw in code with unintended results or allowing sub-optimal usage patterns.
@jacksonquinn

Description

@jacksonquinn
jacksonquinn
opened on Sep 26, 2023

Hello! We're getting a NPE resulting from ConnectionImpl:dryRun here:

java-bigquery/google-cloud-bigquery/src/main/java/com/google/cloud/bigquery/ConnectionImpl.java

Lines 173 to 176 in 3895bd9

List<QueryParameter> queryParametersPb =
dryRunJob.getStatistics().getQuery().getUndeclaredQueryParameters();
List<Parameter> queryParameters =
Lists.transform(queryParametersPb, QUERY_PARAMETER_FROM_PB_FUNCTION);

It looks like getUndeclaredQueryParameters() returns null when there are no undeclared query parameters, but this dryRun function passes that resulting value unchecked into Lists.transform which throws an NPE when the list argument is null.

Metadata

Metadata

Assignees

Labels

api: bigqueryIssues related to the googleapis/java-bigquery API.priority: p2Moderately-important priority. Fix may not be included in next release.type: bugError or flaw in code with unintended results or allowing sub-optimal usage patterns.

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions