build: deploy use of converter config in GCE BUILD rule + DIREGAPIC action#993
Merged
vchudnov-g merged 3 commits intomasterfrom Mar 14, 2025
Merged
build: deploy use of converter config in GCE BUILD rule + DIREGAPIC action#993vchudnov-g merged 3 commits intomasterfrom
vchudnov-g merged 3 commits intomasterfrom
Conversation
vchudnov-g
commented
Mar 13, 2025
| "inlineSchemas" : [{ | ||
| "schema": "", | ||
| "locations": { | ||
| "ErrorSet": [ |
Contributor
Author
There was a problem hiding this comment.
Please confirm this is a reasonable set for this inline schema that was causing the original problem.
vchudnov-g
changed the title
chingor13
approved these changes
Mar 13, 2025
Contributor
chingor13
left a comment
chingor13
left a comment
There was a problem hiding this comment.
Stamping this to unblock. I can't answer your question, so perhaps get confirmation before merging
vchudnov-g
added
the
do not merge
Contributor
Author
|
Adding |
Contributor
Author
|
Thanks! |
vchudnov-g
added
the
owlbot:run
vchudnov-g
force-pushed
the
diregapic-config-deploy
branch
from
324bfd3 to
25ea681
Compare
vchudnov-g
removed
the
do not merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will start working once the
WORKSPACEfile is updated to or past this one; the source-of-truth of that is Google-internal and gets propagated out.