Skip to content

feat: Adding proto_library for bytestream#831

Closed
linzhp wants to merge 1 commit intogoogleapis:masterfrom
linzhp:bytestream
Closed

feat: Adding proto_library for bytestream#831
linzhp wants to merge 1 commit intogoogleapis:masterfrom
linzhp:bytestream

Conversation

@linzhp
Copy link
Copy Markdown

@linzhp linzhp commented Jul 9, 2023

Adding proto_library for bytestream so people can import the proto

@linzhp linzhp changed the title Adding proto_library for bytestream feat: Adding proto_library for bytestream Jul 9, 2023
@conventional-commit-lint-gcf
Copy link
Copy Markdown

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@sluongng
Copy link
Copy Markdown

@linzhp you might need to generate this file instead of manually create it

> bazel run :build_gen -- --src=google/bytestream

Not quite sure if the root api-index-v1.json file needs to be updated as well?

@parthea do you know how should we go about doing this?

@linzhp
Copy link
Copy Markdown
Author

linzhp commented Jul 19, 2023

bazel run :build_gen would create many targets but we only need the proto_library target. I prefer to wait until a real use case to come up to generate those targets.

@alexander-fenster
Copy link
Copy Markdown
Contributor

Hi folks,

We cannot accept pull request here because the content of this repository is synced from the internal repository, but I did generate the BUILD.bazel for google/bytestream in 6ed14f1, hope that works for you!

I'll close this PR, let me know if anything else needs to be fixed.

sluongng added a commit to buildbuddy-io/buildbuddy that referenced this pull request Jan 22, 2024
This includes the change in googleapis/googleapis#831
which let us retire our custom patch.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants