chore: add Go build targets for compute#792
Conversation
codyoss
added
the
automerge
|
Your PR doesn't have any required checks. Please add required checks to your master branch and then re-add the label. Learn more about enabling these checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. |
noahdietz
left a comment
noahdietz
left a comment
There was a problem hiding this comment.
LGTM but can you revert the WORKSPACE changes? these will just be overwritten by copybara / I don't want to introduce a weird copybara push issue.
|
Your PR doesn't have any required checks. Please add required checks to your master branch and then re-add the label. Learn more about enabling these checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. |
|
@noahdietz done. Although I think the changes there are good?!? At least my editor thinks we should format like that 😝 |
They are indeed good, but let's make them in google3 :) |
|
Your PR doesn't have any required checks. Please add required checks to your master branch and then re-add the label. Learn more about enabling these checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. |
2 similar comments
|
Your PR doesn't have any required checks. Please add required checks to your master branch and then re-add the label. Learn more about enabling these checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. |
|
Your PR doesn't have any required checks. Please add required checks to your master branch and then re-add the label. Learn more about enabling these checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. |
2 participants
Note: manually updated proto file, but it yields the same result of the new disco-converter would generate.
Fixes: googleapis/google-cloud-go#7345