fix(compute): revert proto3_optional, required removal on parent_id#714
Merged
fix(compute): revert proto3_optional, required removal on parent_id#714
Conversation
vam-google
approved these changes
Apr 20, 2022
Contributor
vam-google
left a comment
vam-google
left a comment
There was a problem hiding this comment.
LGTM, but cat you please remove exclamation mark from conventional commit message. It will make automation start eleasing compute libraries 2.x which I don't think what we want to do.
noahdietz
changed the title
noahdietz
force-pushed
the
fix-move-parent-id
branch
from
3fd945f to
f0cc68f
Compare
Contributor
Author
Done! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes accidental breaking change in 249e9a1#r71665196.