fix!: handle GCE enum name start with uppercase IPProtocol#691
Merged
summer-ji-eng merged 1 commit intomasterfrom Dec 3, 2021
Merged
fix!: handle GCE enum name start with uppercase IPProtocol#691summer-ji-eng merged 1 commit intomasterfrom
summer-ji-eng merged 1 commit intomasterfrom
Conversation
|
Thanks for your contribution! Unfortunately, we don't use GitHub pull |
google-cla
Bot
added
the
cla: yes
vchudnov-g
approved these changes
Dec 3, 2021
summer-ji-eng
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note: This is a BREAKING CHANGE.
The change is auto generated by latest
disco-to-proto3-converter. The fix PR: googleapis/disco-to-proto3-converter#62.Enum type IPProtocol name(start with uppercase not lowercase) cause the protobufjs compiling error with type name duplicate.
To fix it, we need to rename enum name
IPProtocoltoIPProtocolEnum. This enum name should not affect other languages. Tested on googleapis/googleapis See #689Command to update generated compute.proto: