feat: Switch to string enums for compute#685
Merged
vam-google merged 1 commit intogoogleapis:masterfrom Nov 19, 2021
Merged
Conversation
Also introduce gapic_yaml for java clients to override default LRO configuration (which has too way too long timeouts). Also cleanup regenerate other files (grpc_service_config and service yaml)
|
Thanks for your contribution! Unfortunately, we don't use GitHub pull |
google-cla
Bot
added
the
cla: yes
vchudnov-g
approved these changes
Nov 19, 2021
Contributor
vchudnov-g
left a comment
vchudnov-g
left a comment
There was a problem hiding this comment.
LGTM, but maybe wait for @noahdietz as well.
noahdietz
approved these changes
Nov 19, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also introduce gapic_yaml for java clients to override default LRO configuration (which has way too long timeouts).
Also cleanup and regenerate other files (grpc_service_config and service yaml)