Skip to content

build(python): add service_yaml and rest_numeric_enums configurations for google/cloud/compute builds#1040

Merged
parthea merged 1 commit intomasterfrom
update-compute-build
May 19, 2025
Merged

build(python): add service_yaml and rest_numeric_enums configurations for google/cloud/compute builds#1040
parthea merged 1 commit intomasterfrom
update-compute-build

Conversation

@parthea
Copy link
Copy Markdown
Contributor

@parthea parthea commented May 18, 2025

This PR adds the following configurations for google/cloud/compute Python GAPIC builds

  • rest_numeric_enums
  • service_yaml

Setting rest_numeric_enums to False is a no-op because False is the default value. This was only added for completeness.

https://github.com/googleapis/gapic-generator-python/blob/01aed595d5deffd996410acf6b9f7eca737d027d/rules_python_gapic/py_gapic.bzl#L46

rest_numeric_enums could be set to True in the future however it's not clear what the downstream impact will be. I'd rather not make that change in this PR.

FWIW, the following command works

curl -X GET -H "Authorization: Bearer $(gcloud auth print-access-token)" "https://compute.googleapis.com/compute/v1/projects/<REDACTED PROJECT ID>/aggregated/instances?alt=json%3Benum-encoding%3Dint"

@parthea parthea merged commit 1a22026 into master May 19, 2025
6 checks passed
@parthea parthea deleted the update-compute-build branch May 19, 2025 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants