Conversation
The field was also removed purposefully in v1
The original reference I used had it in the wrong place. Correct GitHub ref: https://docs.github.com/en/actions/writing-workflows/workflow-syntax-for-github-actions#jobsjob_idstrategyfail-fast
PHP just failed. Not clear what the issue is. C# has some known failures. One of them may be the use of 3 repeated fields.
This was causing some errors, too.
sudo is not found!
"version" is the last field, so it has no trailing comma
This reverts commit 489a29c.
| bazelisk build --experimental_convenience_symlinks=normal //google/cloud/compute/v1/... | ||
| bazelisk build --experimental_convenience_symlinks=normal //google/cloud/compute/v1/... | ||
| bazelisk build --experimental_convenience_symlinks=normal //google/cloud/compute/${{ env.compute_version }}/... | ||
| bazelisk build --experimental_convenience_symlinks=normal //google/cloud/compute/${{ env.compute_version }}/... |
There was a problem hiding this comment.
Why are we building twice?
There was a problem hiding this comment.
Great catch! I didn't notice that it was the exact same command. This was part of the existing code. I'm going to go ahead and remove it. If it turns out to be necessary, we can add it back with a comment that explains the reason.
googleapis/.github/workflows/diregapic.yaml
Lines 39 to 40 in 4ad4d7a
There was a problem hiding this comment.
I vaguely recall this was done intentionally, maybe having to do with the bootstrapping process: creating the initial "previous protos" and then using them to make sure the build works both ways. I expect removing the second invocation should at most just increase warnings in some cases.
3 participants
This PR is similar to #1026 but excludes alpha.