feat: add enum Type.GLOBAL

Google APIs · copybara-github · commit f4a56c163276 · 2025-03-25T12:49:47.000-07:00
docs: misc comment updates, formatting

PiperOrigin-RevId: 740451864
diff --git a/google/cloud/apphub/v1/apphub_service.proto b/google/cloud/apphub/v1/apphub_service.proto
@@ -1098,9 +1098,10 @@ message OperationMetadata {
 
   // Output only. Identifies whether the user has requested cancellation
   // of the operation. Operations that have been cancelled successfully
-  // have [Operation.error][] value with a
-  // [google.rpc.Status.code][google.rpc.Status.code] of 1, corresponding to
-  // `Code.CANCELLED`.
+  // have
+  // [google.longrunning.Operation.error][google.longrunning.Operation.error]
+  // value with a [google.rpc.Status.code][google.rpc.Status.code] of 1,
+  // corresponding to `Code.CANCELLED`.
   bool requested_cancellation = 6 [(google.api.field_behavior) = OUTPUT_ONLY];
 
   // Output only. API version used to start the operation.
diff --git a/google/cloud/apphub/v1/application.proto b/google/cloud/apphub/v1/application.proto
@@ -30,7 +30,7 @@ option java_package = "com.google.cloud.apphub.v1";
 option php_namespace = "Google\\Cloud\\AppHub\\V1";
 option ruby_package = "Google::Cloud::AppHub::V1";
 
-// Application defines the governance boundary for App Hub Entities that
+// Application defines the governance boundary for App Hub entities that
 // perform a logical end-to-end business function.
 // App Hub supports application level IAM permission to align with governance
 // requirements.
@@ -58,7 +58,7 @@ message Application {
   }
 
   // Identifier. The resource name of an Application. Format:
-  // "projects/{host-project-id}/locations/{location}/applications/{application-id}"
+  // `"projects/{host-project-id}/locations/{location}/applications/{application-id}"`
   string name = 1 [(google.api.field_behavior) = IDENTIFIER];
 
   // Optional. User-defined name for the Application.
@@ -107,6 +107,9 @@ message Scope {
 
     // Regional type.
     REGIONAL = 1;
+
+    // Global type.
+    GLOBAL = 2;
   }
 
   // Required. Scope Type.
diff --git a/google/cloud/apphub/v1/service.proto b/google/cloud/apphub/v1/service.proto
@@ -31,8 +31,8 @@ option php_namespace = "Google\\Cloud\\AppHub\\V1";
 option ruby_package = "Google::Cloud::AppHub::V1";
 
 // Service is an App Hub data model that contains a discovered service, which
-// represents a network/api interface that exposes some functionality to clients
-// for consumption over the network.
+// represents a network or API interface that exposes some functionality to
+// clients for consumption over the network.
 message Service {
   option (google.api.resource) = {
     type: "apphub.googleapis.com/Service"
@@ -60,7 +60,7 @@ message Service {
   }
 
   // Identifier. The resource name of a Service. Format:
-  // "projects/{host-project-id}/locations/{location}/applications/{application-id}/services/{service-id}"
+  // `"projects/{host-project-id}/locations/{location}/applications/{application-id}/services/{service-id}"`
   string name = 1 [(google.api.field_behavior) = IDENTIFIER];
 
   // Optional. User-defined name for the Service.
@@ -114,8 +114,8 @@ message Service {
 
 // Reference to an underlying networking resource that can comprise a Service.
 message ServiceReference {
-  // Output only. The underlying resource URI (For example, URI of Forwarding
-  // Rule, URL Map, and Backend Service).
+  // Output only. The underlying resource URI. For example, URI of Forwarding
+  // Rule, URL Map, and Backend Service.
   string uri = 1 [(google.api.field_behavior) = OUTPUT_ONLY];
 }
 
@@ -134,9 +134,9 @@ message ServiceProperties {
   string zone = 3 [(google.api.field_behavior) = OUTPUT_ONLY];
 }
 
-// DiscoveredService is a network/api interface that exposes some functionality
-// to clients for consumption over the network. A discovered service can be
-// registered to a App Hub service.
+// DiscoveredService is a network or API interface that exposes some
+// functionality to clients for consumption over the network. A discovered
+// service can be registered to a App Hub service.
 message DiscoveredService {
   option (google.api.resource) = {
     type: "apphub.googleapis.com/DiscoveredService"
@@ -146,7 +146,7 @@ message DiscoveredService {
   };
 
   // Identifier. The resource name of the discovered service. Format:
-  // "projects/{host-project-id}/locations/{location}/discoveredServices/{uuid}""
+  // `"projects/{host-project-id}/locations/{location}/discoveredServices/{uuid}"`
   string name = 1 [(google.api.field_behavior) = IDENTIFIER];
 
   // Output only. Reference to an underlying networking resource that can
diff --git a/google/cloud/apphub/v1/service_project_attachment.proto b/google/cloud/apphub/v1/service_project_attachment.proto
@@ -60,12 +60,12 @@ message ServiceProjectAttachment {
   }
 
   // Identifier. The resource name of a ServiceProjectAttachment. Format:
-  // "projects/{host-project-id}/locations/global/serviceProjectAttachments/{service-project-id}."
+  // `"projects/{host-project-id}/locations/global/serviceProjectAttachments/{service-project-id}."`
   string name = 1 [(google.api.field_behavior) = IDENTIFIER];
 
-  // Required. Immutable. Service project name in the format: "projects/abc" or
-  // "projects/123". As input, project name with either project id or number are
-  // accepted. As output, this field will contain project number.
+  // Required. Immutable. Service project name in the format: `"projects/abc"`
+  // or `"projects/123"`. As input, project name with either project id or
+  // number are accepted. As output, this field will contain project number.
   string service_project = 2 [
     (google.api.field_behavior) = REQUIRED,
     (google.api.field_behavior) = IMMUTABLE,
diff --git a/google/cloud/apphub/v1/workload.proto b/google/cloud/apphub/v1/workload.proto
@@ -61,7 +61,7 @@ message Workload {
   }
 
   // Identifier. The resource name of the Workload. Format:
-  // "projects/{host-project-id}/locations/{location}/applications/{application-id}/workloads/{workload-id}"
+  // `"projects/{host-project-id}/locations/{location}/applications/{application-id}/workloads/{workload-id}"`
   string name = 1 [(google.api.field_behavior) = IDENTIFIER];
 
   // Optional. User-defined name for the Workload.
@@ -122,15 +122,15 @@ message WorkloadReference {
 // Properties of an underlying compute resource represented by the Workload.
 message WorkloadProperties {
   // Output only. The service project identifier that the underlying cloud
-  // resource resides in. Empty for non cloud resources.
+  // resource resides in. Empty for non-cloud resources.
   string gcp_project = 1 [(google.api.field_behavior) = OUTPUT_ONLY];
 
   // Output only. The location that the underlying compute resource resides in
-  // (e.g us-west1).
+  // (for example, us-west1).
   string location = 2 [(google.api.field_behavior) = OUTPUT_ONLY];
 
   // Output only. The location that the underlying compute resource resides in
-  // if it is zonal (e.g us-west1-a).
+  // if it is zonal (for example, us-west1-a).
   string zone = 3 [(google.api.field_behavior) = OUTPUT_ONLY];
 }
 
@@ -147,7 +147,7 @@ message DiscoveredWorkload {
   };
 
   // Identifier. The resource name of the discovered workload. Format:
-  // "projects/{host-project-id}/locations/{location}/discoveredWorkloads/{uuid}"
+  // `"projects/{host-project-id}/locations/{location}/discoveredWorkloads/{uuid}"`
   string name = 1 [(google.api.field_behavior) = IDENTIFIER];
 
   // Output only. Reference of an underlying compute resource represented by the
