Skip to content

Commit e8bd0c4

Browse files
Google APIscopybara-github
authored andcommitted
docs: minor updates in comments
PiperOrigin-RevId: 491785685
1 parent dc4d319 commit e8bd0c4

3 files changed

Lines changed: 21 additions & 12 deletions

File tree

google/cloud/tpu/v1/BUILD.bazel

Lines changed: 16 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -38,6 +38,7 @@ proto_library_with_info(
3838
deps = [
3939
":tpu_proto",
4040
"//google/cloud:common_resources_proto",
41+
"//google/cloud/location:location_proto",
4142
],
4243
)
4344

@@ -67,14 +68,19 @@ java_grpc_library(
6768
java_gapic_library(
6869
name = "tpu_java_gapic",
6970
srcs = [":tpu_proto_with_info"],
71+
gapic_yaml = None,
7072
grpc_service_config = "tpu_grpc_service_config.json",
7173
rest_numeric_enums = False,
74+
service_yaml = "tpu_v1.yaml",
7275
test_deps = [
7376
":tpu_java_grpc",
77+
"//google/cloud/location:location_java_grpc",
7478
],
7579
transport = "grpc",
7680
deps = [
7781
":tpu_java_proto",
82+
"//google/api:api_java_proto",
83+
"//google/cloud/location:location_java_proto",
7884
],
7985
)
8086

@@ -90,7 +96,7 @@ java_gapic_test(
9096
java_gapic_assembly_gradle_pkg(
9197
name = "google-cloud-tpu-v1-java",
9298
include_samples = True,
93-
transport = "grpc",
99+
transport = "grpc+rest",
94100
deps = [
95101
":tpu_java_gapic",
96102
":tpu_java_grpc",
@@ -129,8 +135,10 @@ go_gapic_library(
129135
metadata = True,
130136
rest_numeric_enums = False,
131137
service_yaml = "tpu_v1.yaml",
138+
transport = "grpc+rest",
132139
deps = [
133140
":tpu_go_proto",
141+
"//google/cloud/location:location_go_proto",
134142
"//google/longrunning:longrunning_go_proto",
135143
"@com_google_cloud_go//longrunning:go_default_library",
136144
"@com_google_cloud_go//longrunning/autogen:go_default_library",
@@ -170,7 +178,10 @@ py_gapic_library(
170178
srcs = [":tpu_proto"],
171179
grpc_service_config = "tpu_grpc_service_config.json",
172180
rest_numeric_enums = False,
181+
service_yaml = "tpu_v1.yaml",
173182
transport = "grpc",
183+
deps = [
184+
],
174185
)
175186

176187
py_test(
@@ -292,16 +303,17 @@ ruby_cloud_gapic_library(
292303
name = "tpu_ruby_gapic",
293304
srcs = [":tpu_proto_with_info"],
294305
extra_protoc_parameters = [
295-
"ruby-cloud-gem-name=google-cloud-tpu-v1",
296-
"ruby-cloud-env-prefix=CLOUD_TPU",
297-
"ruby-cloud-product-url=https://cloud.google.com/tpu/",
298306
"ruby-cloud-api-id=tpu.googleapis.com",
299307
"ruby-cloud-api-shortname=tpu",
308+
"ruby-cloud-env-prefix=CLOUD_TPU",
309+
"ruby-cloud-gem-name=google-cloud-tpu-v1",
310+
"ruby-cloud-product-url=https://cloud.google.com/tpu/",
300311
],
301312
grpc_service_config = "tpu_grpc_service_config.json",
302313
rest_numeric_enums = False,
303314
ruby_cloud_description = "Tensor Processing Units (TPUs) are Google's custom-developed application-specific integrated circuits (ASICs) used to accelerate machine learning workloads. Cloud TPUs allow you to access TPUs from Compute Engine, Google Kubernetes Engine and AI Platform.",
304315
ruby_cloud_title = "Cloud TPU V1",
316+
service_yaml = "tpu_v1.yaml",
305317
deps = [
306318
":tpu_ruby_grpc",
307319
":tpu_ruby_proto",

google/cloud/tpu/v1/cloud_tpu.proto

Lines changed: 3 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
// Copyright 2021 Google LLC
1+
// Copyright 2022 Google LLC
22
//
33
// Licensed under the Apache License, Version 2.0 (the "License");
44
// you may not use this file except in compliance with the License.
@@ -88,7 +88,7 @@ service Tpu {
8888
};
8989
}
9090

91-
// Stops a node.
91+
// Stops a node, this operation is only available with single TPU nodes.
9292
rpc StopNode(StopNodeRequest) returns (google.longrunning.Operation) {
9393
option (google.api.http) = {
9494
post: "/v1/{name=projects/*/locations/*/nodes/*}:stop"
@@ -178,7 +178,7 @@ message Node {
178178
// TPU node is being created.
179179
CREATING = 1;
180180

181-
// TPU node has been created and is fully usable.
181+
// TPU node has been created.
182182
READY = 2;
183183

184184
// TPU node is restarting.
@@ -550,11 +550,6 @@ message ListAcceleratorTypesResponse {
550550
repeated string unreachable = 3;
551551
}
552552

553-
// Note: the following OperationMetadata message was added manually.
554-
// This is caused by a conflict with some other message and will
555-
// be resolved separately. Please make sure to add this message back
556-
// if it's removed during public proto regeneration.
557-
558553
// Metadata describing an [Operation][google.longrunning.Operation]
559554
message OperationMetadata {
560555
// The time the operation was created.

google/cloud/tpu/v1/tpu_v1.yaml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,9 @@ name: tpu.googleapis.com
44
title: Cloud TPU API
55

66
apis:
7+
- name: google.cloud.location.Locations
78
- name: google.cloud.tpu.v1.Tpu
9+
- name: google.longrunning.Operations
810

911
types:
1012
- name: google.cloud.tpu.v1.OperationMetadata

0 commit comments

Comments
 (0)