Skip to content

Commit ce08228

Browse files
Google APIscopybara-github
authored andcommitted
feat: add new fields to DatabaseInstance message in the cloud_sql_resources.proto and cleanup proto descriptions
PiperOrigin-RevId: 424175097
1 parent 853e8a2 commit ce08228

5 files changed

Lines changed: 242 additions & 217 deletions

File tree

google/cloud/sql/v1beta4/cloud_sql.proto

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,9 +17,9 @@ syntax = "proto3";
1717
package google.cloud.sql.v1beta4;
1818

1919
import "google/api/annotations.proto";
20+
import "google/api/client.proto";
2021
import "google/api/field_behavior.proto";
2122
import "google/cloud/sql/v1beta4/cloud_sql_resources.proto";
22-
import "google/api/client.proto";
2323

2424
option go_package = "google.golang.org/genproto/googleapis/cloud/sql/v1beta4;sql";
2525
option java_multiple_files = true;

google/cloud/sql/v1beta4/cloud_sql_connect.proto

Lines changed: 15 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -17,11 +17,11 @@ syntax = "proto3";
1717
package google.cloud.sql.v1beta4;
1818

1919
import "google/api/annotations.proto";
20+
import "google/api/client.proto";
2021
import "google/api/field_behavior.proto";
2122
import "google/cloud/sql/v1beta4/cloud_sql_resources.proto";
2223
import "google/protobuf/duration.proto";
2324
import "google/protobuf/timestamp.proto";
24-
import "google/api/client.proto";
2525

2626
option go_package = "google.golang.org/genproto/googleapis/cloud/sql/v1beta4;sql";
2727
option java_multiple_files = true;
@@ -79,24 +79,26 @@ message ConnectSettings {
7979
// The assigned IP addresses for the instance.
8080
repeated IpMapping ip_addresses = 3;
8181

82-
// The cloud region for the instance. e.g. **us-central1**, **europe-west1**.
82+
// The cloud region for the instance. e.g. `us-central1`, `europe-west1`.
8383
// The region cannot be changed after instance creation.
8484
string region = 4;
8585

86-
// The database engine type and version. The **databaseVersion**
86+
// The database engine type and version. The `databaseVersion`
8787
// field cannot be changed after instance creation.
88-
// MySQL instances: **MYSQL_8_0**, **MYSQL_5_7** (default),
89-
// or **MYSQL_5_6**.
90-
// PostgreSQL instances: **POSTGRES_9_6**, **POSTGRES_10**,
91-
// **POSTGRES_11** or **POSTGRES_12** (default).
92-
// SQL Server instances: **SQLSERVER_2017_STANDARD** (default),
93-
// **SQLSERVER_2017_ENTERPRISE**, **SQLSERVER_2017_EXPRESS**, or
94-
// **SQLSERVER_2017_WEB**.
88+
// MySQL instances: `MYSQL_8_0`, `MYSQL_5_7` (default),
89+
// or `MYSQL_5_6`.
90+
// PostgreSQL instances: `POSTGRES_9_6`, `POSTGRES_10`,
91+
// `POSTGRES_11` or `POSTGRES_12` (default), `POSTGRES_13`, or `POSTGRES_14`.
92+
// SQL Server instances: `SQLSERVER_2017_STANDARD` (default),
93+
// `SQLSERVER_2017_ENTERPRISE`, `SQLSERVER_2017_EXPRESS`,
94+
// `SQLSERVER_2017_WEB`, `SQLSERVER_2019_STANDARD`,
95+
// `SQLSERVER_2019_ENTERPRISE`, `SQLSERVER_2019_EXPRESS`, or
96+
// `SQLSERVER_2019_WEB`.
9597
SqlDatabaseVersion database_version = 31;
9698

97-
// **SECOND_GEN**: Cloud SQL database instance.
98-
// **EXTERNAL**: A database server that is not managed by Google.
99-
// This property is read-only; use the **tier** property in the **settings**
99+
// `SECOND_GEN`: Cloud SQL database instance.
100+
// `EXTERNAL`: A database server that is not managed by Google.
101+
// This property is read-only; use the `tier` property in the `settings`
100102
// object to determine the database type.
101103
SqlBackendType backend_type = 32;
102104
}

0 commit comments

Comments
 (0)