fix!: Mark a couple networkconnectivity API fields as required, to match implemented behavior

Google APIs · copybara-github · commit cc003a482a99 · 2021-11-10T13:55:45.000-08:00
PiperOrigin-RevId: 408969147
diff --git a/google/cloud/networkconnectivity/v1/BUILD.bazel b/google/cloud/networkconnectivity/v1/BUILD.bazel
@@ -69,12 +69,15 @@ java_grpc_library(
 java_gapic_library(
     name = "networkconnectivity_java_gapic",
     srcs = [":networkconnectivity_proto_with_info"],
+    gapic_yaml = None,
     grpc_service_config = "networkconnectivity_v1_grpc_service_config.json",
+    service_yaml = "networkconnectivity_v1.yaml",
     test_deps = [
         ":networkconnectivity_java_grpc",
     ],
     deps = [
         ":networkconnectivity_java_proto",
+        "//google/api:api_java_proto",
     ],
 )
 
@@ -124,13 +127,13 @@ go_gapic_library(
     srcs = [":networkconnectivity_proto_with_info"],
     grpc_service_config = "networkconnectivity_v1_grpc_service_config.json",
     importpath = "cloud.google.com/go/networkconnectivity/apiv1;networkconnectivity",
-    service_yaml = "networkconnectivity_v1.yaml",
     metadata = True,
+    service_yaml = "networkconnectivity_v1.yaml",
     deps = [
         ":networkconnectivity_go_proto",
         "//google/longrunning:longrunning_go_proto",
-        "@com_google_cloud_go//longrunning/autogen:go_default_library",
         "@com_google_cloud_go//longrunning:go_default_library",
+        "@com_google_cloud_go//longrunning/autogen:go_default_library",
     ],
 )
 
@@ -146,8 +149,8 @@ go_gapic_assembly_pkg(
     name = "gapi-cloud-networkconnectivity-v1-go",
     deps = [
         ":networkconnectivity_go_gapic",
-        ":networkconnectivity_go_gapic_srcjar-test.srcjar",
         ":networkconnectivity_go_gapic_srcjar-metadata.srcjar",
+        ":networkconnectivity_go_gapic_srcjar-test.srcjar",
         ":networkconnectivity_go_proto",
     ],
 )
@@ -251,8 +254,8 @@ nodejs_gapic_assembly_pkg(
 ##############################################################################
 load(
     "@com_google_googleapis_imports//:imports.bzl",
-    "ruby_gapic_assembly_pkg",
     "ruby_cloud_gapic_library",
+    "ruby_gapic_assembly_pkg",
     "ruby_grpc_library",
     "ruby_proto_library",
 )
diff --git a/google/cloud/networkconnectivity/v1/hub.proto b/google/cloud/networkconnectivity/v1/hub.proto
@@ -164,8 +164,8 @@ service HubService {
   }
 }
 
-// A hub is essentially a collection of spokes. A single hub can contain spokes
-// from multiple regions. However, all of a hub's spokes must be associated with
+// A hub is a collection of spokes. A single hub can contain spokes from
+// multiple regions. However, all of a hub's spokes must be associated with
 // resources that reside in the same VPC network.
 message Hub {
   option (google.api.resource) = {
@@ -225,10 +225,10 @@ enum State {
   DELETING = 3;
 }
 
-// RoutingsVPC contains information about a VPC network that is associated with
+// RoutingVPC contains information about the VPC network that is associated with
 // a hub's spokes.
 message RoutingVPC {
-  // The URI of a VPC network.
+  // The URI of the VPC network.
   string uri = 1 [(google.api.resource_reference) = {
                     type: "compute.googleapis.com/Network"
                   }];
@@ -268,7 +268,7 @@ message Spoke {
   // An optional description of the spoke.
   string description = 5;
 
-  // Immutable. The URI of the hub that this spoke is attached to.
+  // Immutable. The name of the hub that this spoke is attached to.
   string hub = 6 [
     (google.api.field_behavior) = IMMUTABLE,
     (google.api.resource_reference) = {
@@ -351,8 +351,8 @@ message CreateHubRequest {
     }
   ];
 
-  // Optional. A unique identifier for the hub.
-  string hub_id = 2 [(google.api.field_behavior) = OPTIONAL];
+  // Required. A unique identifier for the hub.
+  string hub_id = 2 [(google.api.field_behavior) = REQUIRED];
 
   // Required. The initial values for a new hub.
   Hub hub = 3 [(google.api.field_behavior) = REQUIRED];
@@ -487,8 +487,8 @@ message CreateSpokeRequest {
     }
   ];
 
-  // Optional. Unique id for the spoke to create.
-  string spoke_id = 2 [(google.api.field_behavior) = OPTIONAL];
+  // Required. Unique id for the spoke to create.
+  string spoke_id = 2 [(google.api.field_behavior) = REQUIRED];
 
   // Required. The initial values for a new spoke.
   Spoke spoke = 3 [(google.api.field_behavior) = REQUIRED];
