Skip to content

Commit c392eb0

Browse files
Google APIscopybara-github
Google APIs
authored and
copybara-github
committed
feat!: modified descriptions of validation rules on create entity endpoints
* Commas disallowed * Backslash allowed BREAKING CHANGE: Because of a bug commas have been accepted as part of individual IDs. Fixing this bug is a breaking change but we don't expect users to be impacted as we have detected no individual IDs being generated with commas. Commas are still OK to use as delimiters for lists of multiple IDs. PiperOrigin-RevId: 431967940
1 parent d4f3468 commit c392eb0

4 files changed

Lines changed: 14 additions & 14 deletions

File tree

‎google/maps/fleetengine/delivery/v1/delivery_api.proto‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -137,10 +137,10 @@ message CreateDeliveryVehicleRequest {
137137
//
138138
// * IDs must be valid Unicode strings.
139139
// * IDs are limited to a maximum length of 64 characters.
140-
// * IDs will be normalized according to Unicode Normalization Form C
140+
// * IDs must be normalized according to Unicode Normalization Form C
141141
// (http://www.unicode.org/reports/tr15/).
142142
// * IDs may not contain any of the following ASCII characters: '/', ':',
143-
// '\\', '?', or '#'.
143+
// '?', ',', or '#'.
144144
string delivery_vehicle_id = 4 [(google.api.field_behavior) = REQUIRED];
145145

146146
// Required. The `DeliveryVehicle` entity to create. When creating a new delivery
@@ -264,10 +264,10 @@ message CreateTaskRequest {
264264
//
265265
// * Task IDs must be valid Unicode strings.
266266
// * Task IDs are limited to a maximum length of 64 characters.
267-
// * Task IDs will be normalized according to Unicode Normalization Form C
267+
// * Task IDs must be normalized according to Unicode Normalization Form C
268268
// (http://www.unicode.org/reports/tr15/).
269269
// * Task IDs may not contain any of the following ASCII characters: '/',
270-
// ':', '\\', '?', or '#'.
270+
// ':', '?', ',', or '#'.
271271
string task_id = 5 [(google.api.field_behavior) = REQUIRED];
272272

273273
// Required. The Task entity to create.

‎google/maps/fleetengine/delivery/v1/tasks.proto‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -171,10 +171,10 @@ message Task {
171171
//
172172
// * Tracking IDs must be valid Unicode strings.
173173
// * Tracking IDs are limited to a maximum length of 64 characters.
174-
// * Tracking IDs will be normalized according to Unicode Normalization Form C
174+
// * Tracking IDs must be normalized according to Unicode Normalization Form C
175175
// (http://www.unicode.org/reports/tr15/).
176176
// * Tracking IDs may not contain any of the following ASCII characters: '/',
177-
// ':', '\\', '?', or '#'.
177+
// ':', '?', ',', or '#'.
178178
string tracking_id = 4 [(google.api.field_behavior) = IMMUTABLE];
179179

180180
// Output only. The ID of the vehicle that is executing this Task.

‎google/maps/fleetengine/v1/trip_api.proto‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -97,12 +97,12 @@ message CreateTripRequest {
9797
// Required. Unique Trip ID; must be unique per provider.
9898
// Subject to the following restrictions:
9999
//
100-
// 1. IDs must not contain any of the following ASCII characters: '/', ':',
101-
// '?', or '#'.
100+
// 1. IDs must be valid Unicode strings.
102101
// 2. IDs are limited to a maximum length of 64 characters.
103-
// 3. IDs must be valid Unicode strings.
104-
// 4. IDs must be normalized according to Unicode Normalization Form C
102+
// 3. IDs must be normalized according to Unicode Normalization Form C
105103
// (http://www.unicode.org/reports/tr15/).
104+
// 4. IDs must not contain any of the following ASCII characters: '/', ':',
105+
// '?', ',', or '#'.
106106
string trip_id = 5 [(google.api.field_behavior) = REQUIRED];
107107

108108
// Required. Trip entity to create.

‎google/maps/fleetengine/v1/vehicle_api.proto‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -170,12 +170,12 @@ message CreateVehicleRequest {
170170
// Required. Unique Vehicle ID; must be unique per provider.
171171
// Subject to the following restrictions:
172172
//
173-
// 1. IDs must not contain any of the following ASCII characters: '/', ':',
174-
// '?', or '#'.
173+
// 1. IDs must be valid Unicode strings.
175174
// 2. IDs are limited to a maximum length of 64 characters.
176-
// 3. IDs must be valid Unicode strings.
177-
// 4. IDs must be normalized according to Unicode Normalization Form C
175+
// 3. IDs must be normalized according to Unicode Normalization Form C
178176
// (http://www.unicode.org/reports/tr15/).
177+
// 4. IDs must not contain any of the following ASCII characters: '/', ':',
178+
// '?', ',', or '#'.
179179
string vehicle_id = 4 [(google.api.field_behavior) = REQUIRED];
180180

181181
// Required. The Vehicle entity to create. When creating a Vehicle, the following

0 commit comments

Comments
 (0)