Skip to content

Commit c34b78b

Browse files
Google APIscopybara-github
Google APIs
authored and
copybara-github
committed
feat: Add comment to the unsupported order_by field of ListTasksRequest
--- feat: Enable gpu driver version field on v1 --- feat: allow order_by for v1 ListJobs --- feat: Improve url examples formats on Batch API comments PiperOrigin-RevId: 552573521
1 parent 992c4f4 commit c34b78b

2 files changed

Lines changed: 48 additions & 16 deletions

File tree

‎google/cloud/batch/v1/batch.proto‎

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -177,6 +177,10 @@ message ListJobsRequest {
177177
// List filter.
178178
string filter = 4;
179179

180+
// Optional. Sort results. Supported are "name", "name desc", "create_time",
181+
// and "create_time desc".
182+
string order_by = 5 [(google.api.field_behavior) = OPTIONAL];
183+
180184
// Page size.
181185
int32 page_size = 2;
182186

‎google/cloud/batch/v1/job.proto‎

Lines changed: 44 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -249,21 +249,24 @@ message AllocationPolicy {
249249
message Disk {
250250
// A data source from which a PD will be created.
251251
oneof data_source {
252-
// Name of a public or custom image used as the data source.
252+
// Name of an image used as the data source.
253253
// For example, the following are all valid URLs:
254254
//
255255
// * Specify the image by its family name:
256-
// projects/{project}/global/images/family/{image_family}
256+
// <pre><code>projects/<var
257+
// class="apiparam">project</var>/global/images/family/<var
258+
// class="apiparam">image_family</var></code></pre>
257259
// * Specify the image version:
258-
// projects/{project}/global/images/{image_version}
259-
//
260+
// <pre>projects/<var
261+
// class="apiparam">project</var>/global/images/<var
262+
// class="apiparam">image_version</var></code></pre>
260263
// You can also use Batch customized image in short names.
261264
// The following image values are supported for a boot disk:
262265
//
263-
// * "batch-debian": use Batch Debian images.
264-
// * "batch-centos": use Batch CentOS images.
265-
// * "batch-cos": use Batch Container-Optimized images.
266-
// * "batch-hpc-centos": use Batch HPC CentOS images.
266+
// * `batch-debian`: use Batch Debian images.
267+
// * `batch-centos`: use Batch CentOS images.
268+
// * `batch-cos`: use Batch Container-Optimized images.
269+
// * `batch-hpc-centos`: use Batch HPC CentOS images.
267270
string image = 4;
268271

269272
// Name of a snapshot used as the data source.
@@ -323,6 +326,15 @@ message AllocationPolicy {
323326

324327
// Deprecated: please use instances[0].install_gpu_drivers instead.
325328
bool install_gpu_drivers = 3 [deprecated = true];
329+
330+
// Optional. The NVIDIA GPU driver version that should be installed for this
331+
// type.
332+
//
333+
// You can define the specific driver version such as "470.103.01",
334+
// following the driver version requirements in
335+
// https://cloud.google.com/compute/docs/gpus/install-drivers-gpu#minimum-driver.
336+
// Batch will install the specific accelerator driver if qualified.
337+
string driver_version = 4 [(google.api.field_behavior) = OPTIONAL];
326338
}
327339

328340
// InstancePolicy describes an instance type and resources attached to each VM
@@ -368,6 +380,12 @@ message AllocationPolicy {
368380
// third party location and install them for GPUs specified in
369381
// policy.accelerators or instance_template on their behalf. Default is
370382
// false.
383+
//
384+
// For Container-Optimized Image cases, Batch will install the
385+
// accelerator driver following milestones of
386+
// https://cloud.google.com/container-optimized-os/docs/release-notes. For
387+
// non Container-Optimized Image cases, following
388+
// https://github.com/GoogleCloudPlatform/compute-gpu-installation/blob/main/linux/install_gpu_driver.py.
371389
bool install_gpu_drivers = 3;
372390
}
373391

@@ -377,20 +395,30 @@ message AllocationPolicy {
377395
// You can specify the network as a full or partial URL.
378396
//
379397
// For example, the following are all valid URLs:
380-
//
381-
// * https://www.googleapis.com/compute/v1/projects/{project}/global/networks/{network}
382-
// * projects/{project}/global/networks/{network}
383-
// * global/networks/{network}
398+
// <pre><code>https://www.googleapis.com/compute/v1/projects/<var
399+
// class="apiparam">project</var>/global/networks/<var
400+
// class="apiparam">network</var></code></pre>
401+
// <pre><code>projects/<var
402+
// class="apiparam">project</var>/global/networks/<var
403+
// class="apiparam">network</var></code></pre>
404+
// <pre><code>global/networks/<var
405+
// class="apiparam">network</var></code></pre>
384406
string network = 1;
385407

386408
// The URL of an existing subnetwork resource in the network.
387409
// You can specify the subnetwork as a full or partial URL.
388410
//
389411
// For example, the following are all valid URLs:
390-
//
391-
// * https://www.googleapis.com/compute/v1/projects/{project}/regions/{region}/subnetworks/{subnetwork}
392-
// * projects/{project}/regions/{region}/subnetworks/{subnetwork}
393-
// * regions/{region}/subnetworks/{subnetwork}
412+
// <pre><code>https://www.googleapis.com/compute/v1/projects/<var
413+
// class="apiparam">project</var>/regions/<var
414+
// class="apiparam">region</var>/subnetworks/<var
415+
// class="apiparam">subnetwork</var></code></pre>
416+
// <pre><code>projects/<var class="apiparam">project</var>/regions/<var
417+
// class="apiparam">region</var>/subnetworks/<var
418+
// class="apiparam">subnetwork</var></code></pre>
419+
// <pre><code>regions/<var
420+
// class="apiparam">region</var>/subnetworks/<var
421+
// class="apiparam">subnetwork</var></code></pre>
394422
string subnetwork = 2;
395423

396424
// Default is false (with an external IP address). Required if

0 commit comments

Comments
 (0)