Skip to content

Commit c27097e

Browse files
Google APIscopybara-github
authored andcommitted
docs: Comments are clarified for certain fields in messages QueryAssetsResponse and ResourceSearchResult
PiperOrigin-RevId: 673500457
1 parent 41cd9db commit c27097e

2 files changed

Lines changed: 8 additions & 6 deletions

File tree

google/cloud/asset/v1/asset_service.proto

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1996,10 +1996,12 @@ message QueryAssetsResponse {
19961996

19971997
// The query response, which can be either an `error` or a valid `response`.
19981998
//
1999-
// If `done` == `false` and the query result is being saved in a output, the
1999+
// If `done` == `false` and the query result is being saved in an output, the
20002000
// output_config field will be set.
20012001
// If `done` == `true`, exactly one of
20022002
// `error`, `query_result` or `output_config` will be set.
2003+
// [done] is unset unless the [QueryAssetsResponse] contains a
2004+
// [QueryAssetsResponse.job_reference].
20032005
bool done = 2;
20042006

20052007
oneof response {
@@ -2009,8 +2011,9 @@ message QueryAssetsResponse {
20092011
// Result of the query.
20102012
QueryResult query_result = 4;
20112013

2012-
// Output configuration which indicates instead of being returned in API
2013-
// response on the fly, the query result will be saved in a specific output.
2014+
// Output configuration, which indicates that instead of being returned in
2015+
// an API response on the fly, the query result will be saved in a specific
2016+
// output.
20142017
QueryAssetsOutputConfig output_config = 5;
20152018
}
20162019
}

google/cloud/asset/v1/assets.proto

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -341,7 +341,6 @@ message EffectiveTagDetails {
341341
}
342342

343343
// A result of Resource Search, containing information of a cloud resource.
344-
// Next ID: 34
345344
message ResourceSearchResult {
346345
// The full resource name of this resource. Example:
347346
// `//compute.googleapis.com/projects/my_project_123/zones/zone1/instances/instance1`.
@@ -424,8 +423,8 @@ message ResourceSearchResult {
424423
// * Use a free text query. Example: `us-west*`
425424
string location = 6;
426425

427-
// Labels associated with this resource. See [Labelling and grouping Google
428-
// Cloud
426+
// User labels associated with this resource. See [Labelling and grouping
427+
// Google Cloud
429428
// resources](https://cloud.google.com/blog/products/gcp/labelling-and-grouping-your-google-cloud-platform-resources)
430429
// for more information. This field is available only when the resource's
431430
// Protobuf contains it.

0 commit comments

Comments
 (0)