Skip to content

Commit bc3c83b

Browse files
Google APIscopybara-github
authored andcommitted
feat: Add support for Cloud Bigtable Request Priorities in App Profiles
PiperOrigin-RevId: 571158646
1 parent aa829ea commit bc3c83b

3 files changed

Lines changed: 123 additions & 70 deletions

File tree

google/bigtable/admin/v2/bigtable_instance_admin.proto

Lines changed: 59 additions & 47 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
// Copyright 2022 Google LLC
1+
// Copyright 2023 Google LLC
22
//
33
// Licensed under the Apache License, Version 2.0 (the "License");
44
// you may not use this file except in compliance with the License.
@@ -57,12 +57,14 @@ service BigtableInstanceAdmin {
5757
// serve_nodes is set to non-zero, then the cluster is manually scaled. If
5858
// cluster_config.cluster_autoscaling_config is non-empty, then autoscaling is
5959
// enabled.
60-
rpc CreateInstance(CreateInstanceRequest) returns (google.longrunning.Operation) {
60+
rpc CreateInstance(CreateInstanceRequest)
61+
returns (google.longrunning.Operation) {
6162
option (google.api.http) = {
6263
post: "/v2/{parent=projects/*}/instances"
6364
body: "*"
6465
};
65-
option (google.api.method_signature) = "parent,instance_id,instance,clusters";
66+
option (google.api.method_signature) =
67+
"parent,instance_id,instance,clusters";
6668
option (google.longrunning.operation_info) = {
6769
response_type: "Instance"
6870
metadata_type: "CreateInstanceMetadata"
@@ -97,7 +99,8 @@ service BigtableInstanceAdmin {
9799

98100
// Partially updates an instance within a project. This method can modify all
99101
// fields of an Instance and is the preferred way to update an Instance.
100-
rpc PartialUpdateInstance(PartialUpdateInstanceRequest) returns (google.longrunning.Operation) {
102+
rpc PartialUpdateInstance(PartialUpdateInstanceRequest)
103+
returns (google.longrunning.Operation) {
101104
option (google.api.http) = {
102105
patch: "/v2/{instance.name=projects/*/instances/*}"
103106
body: "instance"
@@ -124,7 +127,8 @@ service BigtableInstanceAdmin {
124127
// serve_nodes is set to non-zero, then the cluster is manually scaled. If
125128
// cluster_config.cluster_autoscaling_config is non-empty, then autoscaling is
126129
// enabled.
127-
rpc CreateCluster(CreateClusterRequest) returns (google.longrunning.Operation) {
130+
rpc CreateCluster(CreateClusterRequest)
131+
returns (google.longrunning.Operation) {
128132
option (google.api.http) = {
129133
post: "/v2/{parent=projects/*/instances/*}/clusters"
130134
body: "cluster"
@@ -180,7 +184,8 @@ service BigtableInstanceAdmin {
180184
//
181185
// To disable autoscaling, clear cluster_config.cluster_autoscaling_config,
182186
// and explicitly set a serve_node count via the update_mask.
183-
rpc PartialUpdateCluster(PartialUpdateClusterRequest) returns (google.longrunning.Operation) {
187+
rpc PartialUpdateCluster(PartialUpdateClusterRequest)
188+
returns (google.longrunning.Operation) {
184189
option (google.api.http) = {
185190
patch: "/v2/{cluster.name=projects/*/instances/*/clusters/*}"
186191
body: "cluster"
@@ -218,15 +223,17 @@ service BigtableInstanceAdmin {
218223
}
219224

220225
// Lists information about app profiles in an instance.
221-
rpc ListAppProfiles(ListAppProfilesRequest) returns (ListAppProfilesResponse) {
226+
rpc ListAppProfiles(ListAppProfilesRequest)
227+
returns (ListAppProfilesResponse) {
222228
option (google.api.http) = {
223229
get: "/v2/{parent=projects/*/instances/*}/appProfiles"
224230
};
225231
option (google.api.method_signature) = "parent";
226232
}
227233

228234
// Updates an app profile within an instance.
229-
rpc UpdateAppProfile(UpdateAppProfileRequest) returns (google.longrunning.Operation) {
235+
rpc UpdateAppProfile(UpdateAppProfileRequest)
236+
returns (google.longrunning.Operation) {
230237
option (google.api.http) = {
231238
patch: "/v2/{app_profile.name=projects/*/instances/*/appProfiles/*}"
232239
body: "app_profile"
@@ -239,7 +246,8 @@ service BigtableInstanceAdmin {
239246
}
240247

241248
// Deletes an app profile from an instance.
242-
rpc DeleteAppProfile(DeleteAppProfileRequest) returns (google.protobuf.Empty) {
249+
rpc DeleteAppProfile(DeleteAppProfileRequest)
250+
returns (google.protobuf.Empty) {
243251
option (google.api.http) = {
244252
delete: "/v2/{name=projects/*/instances/*/appProfiles/*}"
245253
};
@@ -248,7 +256,8 @@ service BigtableInstanceAdmin {
248256

249257
// Gets the access control policy for an instance resource. Returns an empty
250258
// policy if an instance exists but does not have a policy set.
251-
rpc GetIamPolicy(google.iam.v1.GetIamPolicyRequest) returns (google.iam.v1.Policy) {
259+
rpc GetIamPolicy(google.iam.v1.GetIamPolicyRequest)
260+
returns (google.iam.v1.Policy) {
252261
option (google.api.http) = {
253262
post: "/v2/{resource=projects/*/instances/*}:getIamPolicy"
254263
body: "*"
@@ -258,7 +267,8 @@ service BigtableInstanceAdmin {
258267

259268
// Sets the access control policy on an instance resource. Replaces any
260269
// existing policy.
261-
rpc SetIamPolicy(google.iam.v1.SetIamPolicyRequest) returns (google.iam.v1.Policy) {
270+
rpc SetIamPolicy(google.iam.v1.SetIamPolicyRequest)
271+
returns (google.iam.v1.Policy) {
262272
option (google.api.http) = {
263273
post: "/v2/{resource=projects/*/instances/*}:setIamPolicy"
264274
body: "*"
@@ -267,7 +277,8 @@ service BigtableInstanceAdmin {
267277
}
268278

269279
// Returns permissions that the caller has on the specified instance resource.
270-
rpc TestIamPermissions(google.iam.v1.TestIamPermissionsRequest) returns (google.iam.v1.TestIamPermissionsResponse) {
280+
rpc TestIamPermissions(google.iam.v1.TestIamPermissionsRequest)
281+
returns (google.iam.v1.TestIamPermissionsResponse) {
271282
option (google.api.http) = {
272283
post: "/v2/{resource=projects/*/instances/*}:testIamPermissions"
273284
body: "*"
@@ -287,17 +298,17 @@ service BigtableInstanceAdmin {
287298

288299
// Request message for BigtableInstanceAdmin.CreateInstance.
289300
message CreateInstanceRequest {
290-
// Required. The unique name of the project in which to create the new instance.
291-
// Values are of the form `projects/{project}`.
301+
// Required. The unique name of the project in which to create the new
302+
// instance. Values are of the form `projects/{project}`.
292303
string parent = 1 [
293304
(google.api.field_behavior) = REQUIRED,
294305
(google.api.resource_reference) = {
295306
type: "cloudresourcemanager.googleapis.com/Project"
296307
}
297308
];
298309

299-
// Required. The ID to be used when referring to the new instance within its project,
300-
// e.g., just `myinstance` rather than
310+
// Required. The ID to be used when referring to the new instance within its
311+
// project, e.g., just `myinstance` rather than
301312
// `projects/myproject/instances/myinstance`.
302313
string instance_id = 2 [(google.api.field_behavior) = REQUIRED];
303314

@@ -327,8 +338,8 @@ message GetInstanceRequest {
327338

328339
// Request message for BigtableInstanceAdmin.ListInstances.
329340
message ListInstancesRequest {
330-
// Required. The unique name of the project for which a list of instances is requested.
331-
// Values are of the form `projects/{project}`.
341+
// Required. The unique name of the project for which a list of instances is
342+
// requested. Values are of the form `projects/{project}`.
332343
string parent = 1 [
333344
(google.api.field_behavior) = REQUIRED,
334345
(google.api.resource_reference) = {
@@ -364,7 +375,8 @@ message PartialUpdateInstanceRequest {
364375

365376
// Required. The subset of Instance fields which should be replaced.
366377
// Must be explicitly set.
367-
google.protobuf.FieldMask update_mask = 2 [(google.api.field_behavior) = REQUIRED];
378+
google.protobuf.FieldMask update_mask = 2
379+
[(google.api.field_behavior) = REQUIRED];
368380
}
369381

370382
// Request message for BigtableInstanceAdmin.DeleteInstance.
@@ -381,18 +393,17 @@ message DeleteInstanceRequest {
381393

382394
// Request message for BigtableInstanceAdmin.CreateCluster.
383395
message CreateClusterRequest {
384-
// Required. The unique name of the instance in which to create the new cluster.
385-
// Values are of the form
386-
// `projects/{project}/instances/{instance}`.
396+
// Required. The unique name of the instance in which to create the new
397+
// cluster. Values are of the form `projects/{project}/instances/{instance}`.
387398
string parent = 1 [
388399
(google.api.field_behavior) = REQUIRED,
389400
(google.api.resource_reference) = {
390401
type: "bigtableadmin.googleapis.com/Instance"
391402
}
392403
];
393404

394-
// Required. The ID to be used when referring to the new cluster within its instance,
395-
// e.g., just `mycluster` rather than
405+
// Required. The ID to be used when referring to the new cluster within its
406+
// instance, e.g., just `mycluster` rather than
396407
// `projects/myproject/instances/myinstance/clusters/mycluster`.
397408
string cluster_id = 2 [(google.api.field_behavior) = REQUIRED];
398409

@@ -415,10 +426,11 @@ message GetClusterRequest {
415426

416427
// Request message for BigtableInstanceAdmin.ListClusters.
417428
message ListClustersRequest {
418-
// Required. The unique name of the instance for which a list of clusters is requested.
419-
// Values are of the form `projects/{project}/instances/{instance}`.
420-
// Use `{instance} = '-'` to list Clusters for all Instances in a project,
421-
// e.g., `projects/myproject/instances/-`.
429+
// Required. The unique name of the instance for which a list of clusters is
430+
// requested. Values are of the form
431+
// `projects/{project}/instances/{instance}`. Use `{instance} = '-'` to list
432+
// Clusters for all Instances in a project, e.g.,
433+
// `projects/myproject/instances/-`.
422434
string parent = 1 [
423435
(google.api.field_behavior) = REQUIRED,
424436
(google.api.resource_reference) = {
@@ -448,8 +460,8 @@ message ListClustersResponse {
448460

449461
// Request message for BigtableInstanceAdmin.DeleteCluster.
450462
message DeleteClusterRequest {
451-
// Required. The unique name of the cluster to be deleted. Values are of the form
452-
// `projects/{project}/instances/{instance}/clusters/{cluster}`.
463+
// Required. The unique name of the cluster to be deleted. Values are of the
464+
// form `projects/{project}/instances/{instance}/clusters/{cluster}`.
453465
string name = 1 [
454466
(google.api.field_behavior) = REQUIRED,
455467
(google.api.resource_reference) = {
@@ -561,28 +573,28 @@ message PartialUpdateClusterMetadata {
561573

562574
// Request message for BigtableInstanceAdmin.PartialUpdateCluster.
563575
message PartialUpdateClusterRequest {
564-
// Required. The Cluster which contains the partial updates to be applied, subject to
565-
// the update_mask.
576+
// Required. The Cluster which contains the partial updates to be applied,
577+
// subject to the update_mask.
566578
Cluster cluster = 1 [(google.api.field_behavior) = REQUIRED];
567579

568580
// Required. The subset of Cluster fields which should be replaced.
569-
google.protobuf.FieldMask update_mask = 2 [(google.api.field_behavior) = REQUIRED];
581+
google.protobuf.FieldMask update_mask = 2
582+
[(google.api.field_behavior) = REQUIRED];
570583
}
571584

572585
// Request message for BigtableInstanceAdmin.CreateAppProfile.
573586
message CreateAppProfileRequest {
574-
// Required. The unique name of the instance in which to create the new app profile.
575-
// Values are of the form
576-
// `projects/{project}/instances/{instance}`.
587+
// Required. The unique name of the instance in which to create the new app
588+
// profile. Values are of the form `projects/{project}/instances/{instance}`.
577589
string parent = 1 [
578590
(google.api.field_behavior) = REQUIRED,
579591
(google.api.resource_reference) = {
580592
type: "bigtableadmin.googleapis.com/Instance"
581593
}
582594
];
583595

584-
// Required. The ID to be used when referring to the new app profile within its
585-
// instance, e.g., just `myprofile` rather than
596+
// Required. The ID to be used when referring to the new app profile within
597+
// its instance, e.g., just `myprofile` rather than
586598
// `projects/myproject/instances/myinstance/appProfiles/myprofile`.
587599
string app_profile_id = 2 [(google.api.field_behavior) = REQUIRED];
588600

@@ -596,8 +608,8 @@ message CreateAppProfileRequest {
596608

597609
// Request message for BigtableInstanceAdmin.GetAppProfile.
598610
message GetAppProfileRequest {
599-
// Required. The unique name of the requested app profile. Values are of the form
600-
// `projects/{project}/instances/{instance}/appProfiles/{app_profile}`.
611+
// Required. The unique name of the requested app profile. Values are of the
612+
// form `projects/{project}/instances/{instance}/appProfiles/{app_profile}`.
601613
string name = 1 [
602614
(google.api.field_behavior) = REQUIRED,
603615
(google.api.resource_reference) = {
@@ -608,8 +620,8 @@ message GetAppProfileRequest {
608620

609621
// Request message for BigtableInstanceAdmin.ListAppProfiles.
610622
message ListAppProfilesRequest {
611-
// Required. The unique name of the instance for which a list of app profiles is
612-
// requested. Values are of the form
623+
// Required. The unique name of the instance for which a list of app profiles
624+
// is requested. Values are of the form
613625
// `projects/{project}/instances/{instance}`.
614626
// Use `{instance} = '-'` to list AppProfiles for all Instances in a project,
615627
// e.g., `projects/myproject/instances/-`.
@@ -659,15 +671,17 @@ message UpdateAppProfileRequest {
659671

660672
// Required. The subset of app profile fields which should be replaced.
661673
// If unset, all fields will be replaced.
662-
google.protobuf.FieldMask update_mask = 2 [(google.api.field_behavior) = REQUIRED];
674+
google.protobuf.FieldMask update_mask = 2
675+
[(google.api.field_behavior) = REQUIRED];
663676

664677
// If true, ignore safety checks when updating the app profile.
665678
bool ignore_warnings = 3;
666679
}
667680

668681
// Request message for BigtableInstanceAdmin.DeleteAppProfile.
669682
message DeleteAppProfileRequest {
670-
// Required. The unique name of the app profile to be deleted. Values are of the form
683+
// Required. The unique name of the app profile to be deleted. Values are of
684+
// the form
671685
// `projects/{project}/instances/{instance}/appProfiles/{app_profile}`.
672686
string name = 1 [
673687
(google.api.field_behavior) = REQUIRED,
@@ -681,9 +695,7 @@ message DeleteAppProfileRequest {
681695
}
682696

683697
// The metadata for the Operation returned by UpdateAppProfile.
684-
message UpdateAppProfileMetadata {
685-
686-
}
698+
message UpdateAppProfileMetadata {}
687699

688700
// Request message for BigtableInstanceAdmin.ListHotTablets.
689701
message ListHotTabletsRequest {

google/bigtable/admin/v2/common.proto

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
// Copyright 2022 Google LLC
1+
// Copyright 2023 Google LLC
22
//
33
// Licensed under the Apache License, Version 2.0 (the "License");
44
// you may not use this file except in compliance with the License.

0 commit comments

Comments
 (0)