fix!: BREAKING_CHANGE: remove display_name from FeatureStore

Google APIs · copybara-github · commit b96db5aeb026 · 2021-05-10T10:02:57.000-07:00
feat: add invalid_row_count to ImportFeatureValuesResponse and ImportFeatureValuesOperationMetadata

PiperOrigin-RevId: 372952726
diff --git a/google/cloud/aiplatform/v1beta1/accelerator_type.proto b/google/cloud/aiplatform/v1beta1/accelerator_type.proto
@@ -42,4 +42,7 @@ enum AcceleratorType {
 
   // Nvidia Tesla T4 GPU.
   NVIDIA_TESLA_T4 = 5;
+
+  // Nvidia Tesla A100 GPU.
+  NVIDIA_TESLA_A100 = 8;
 }
diff --git a/google/cloud/aiplatform/v1beta1/featurestore.proto b/google/cloud/aiplatform/v1beta1/featurestore.proto
@@ -67,13 +67,6 @@ message Featurestore {
   // `projects/{project}/locations/{location}/featurestores/{featurestore}`
   string name = 1 [(google.api.field_behavior) = OUTPUT_ONLY];
 
-  // Required. The user-defined name of the Featurestore.
-  // The name can be up to 128 characters long and can consist of any UTF-8
-  // characters.
-  // Display name of a Featurestore must be unique within a single Project and
-  // Location Pair.
-  string display_name = 2 [(google.api.field_behavior) = REQUIRED];
-
   // Output only. Timestamp when this Featurestore was created.
   google.protobuf.Timestamp create_time = 3 [(google.api.field_behavior) = OUTPUT_ONLY];
 
diff --git a/google/cloud/aiplatform/v1beta1/featurestore_service.proto b/google/cloud/aiplatform/v1beta1/featurestore_service.proto
@@ -413,7 +413,7 @@ message UpdateFeaturestoreRequest {
   //   * `display_name`
   //   * `labels`
   //   * `online_serving_config.fixed_node_count`
-  //   * `online_serving_config.max_online_serving_size`
+  //   * `retention_policy.online_storage_ttl_days`
   google.protobuf.FieldMask update_mask = 2;
 }
 
@@ -510,6 +510,13 @@ message ImportFeatureValuesResponse {
 
   // Number of Feature values that have been imported by the operation.
   int64 imported_feature_value_count = 2;
+
+  // The number of rows in input source that weren't imported due to either
+  // * Not having any featureValues.
+  // * Having a null entityId.
+  // * Having a null timestamp.
+  // * Not being parsable (applicable for CSV sources).
+  int64 invalid_row_count = 6;
 }
 
 // Request message for [FeaturestoreService.BatchReadFeatureValues][google.cloud.aiplatform.v1beta1.FeaturestoreService.BatchReadFeatureValues].
@@ -1124,6 +1131,13 @@ message ImportFeatureValuesOperationMetadata {
 
   // Number of feature values that have been imported by the operation.
   int64 imported_feature_value_count = 3;
+
+  // The number of rows in input source that weren't imported due to either
+  // * Not having any featureValues.
+  // * Having a null entityId.
+  // * Having a null timestamp.
+  // * Not being parsable (applicable for CSV sources).
+  int64 invalid_row_count = 6;
 }
 
 // Details of operations that exports Features values.
diff --git a/google/cloud/aiplatform/v1beta1/index_service.proto b/google/cloud/aiplatform/v1beta1/index_service.proto
@@ -237,7 +237,7 @@ message NearestNeighborSearchOperationMetadata {
     // should check against error_type as the source of truth.
     string error_message = 2;
 
-    // GCS uri pointing to the original file in user's bucket.
+    // Cloud Storage URI pointing to the original file in user's bucket.
     string source_gcs_uri = 3;
 
     // Empty if the embedding id is failed to parse.
@@ -248,7 +248,7 @@ message NearestNeighborSearchOperationMetadata {
   }
 
   message ContentValidationStats {
-    // GCS uri pointing to the original file in user's bucket.
+    // Cloud Storage URI pointing to the original file in user's bucket.
     string source_gcs_uri = 1;
 
     // Number of records in this file that were successfully processed.
diff --git a/google/cloud/aiplatform/v1beta1/tensorboard.proto b/google/cloud/aiplatform/v1beta1/tensorboard.proto
@@ -27,7 +27,7 @@ option java_multiple_files = true;
 option java_outer_classname = "TensorboardProto";
 option java_package = "com.google.cloud.aiplatform.v1beta1";
 
-// Tensorboard is a physical database that stores users’ training metrics.
+// Tensorboard is a physical database that stores users' training metrics.
 // A default Tensorboard is provided in each region of a GCP project.
 // If needed users can also create extra Tensorboards in their projects.
 message Tensorboard {

Original file line number	Diff line number	Diff line change
`@@ -42,4 +42,7 @@ enum AcceleratorType {`
`42`	`42`
`43`	`43`	`// Nvidia Tesla T4 GPU.`
`44`	`44`	`NVIDIA_TESLA_T4 = 5;`
	`45`	`+`
	`46`	`+ // Nvidia Tesla A100 GPU.`
	`47`	`+ NVIDIA_TESLA_A100 = 8;`
`45`	`48`	`}`