Skip to content

Commit b755429

Browse files
Google APIscopybara-github
authored andcommitted
chore: update AdMob v1 build to use Java, Python microgenerators
Committer: @aohren PiperOrigin-RevId: 358377205
1 parent 959b0bc commit b755429

2 files changed

Lines changed: 15 additions & 36 deletions

File tree

google/ads/admob/BUILD.bazel

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
exports_files(glob(["*.yaml"]))
1+
exports_files(["admob_grpc_service_config.json"] + glob(["*.yaml"]))

google/ads/admob/v1/BUILD.bazel

Lines changed: 14 additions & 35 deletions
Original file line numberDiff line numberDiff line change
@@ -30,14 +30,14 @@ proto_library(
3030
"//google/api:field_behavior_proto",
3131
"//google/api:resource_proto",
3232
"//google/type:date_proto",
33+
"//google/cloud:common_resources_proto",
3334
],
3435
)
3536

3637
proto_library_with_info(
3738
name = "admob_proto_with_info",
3839
deps = [
3940
":admob_proto",
40-
"//google/cloud:common_resources_proto",
4141
],
4242
)
4343

@@ -48,9 +48,9 @@ load(
4848
"@com_google_googleapis_imports//:imports.bzl",
4949
"java_grpc_library",
5050
"java_proto_library",
51-
java_gapic_assembly_gradle_pkg = "java_gapic_assembly_gradle_pkg_legacy",
52-
java_gapic_library = "java_gapic_library_legacy",
53-
java_gapic_test = "java_gapic_test_legacy",
51+
"java_gapic_assembly_gradle_pkg",
52+
"java_gapic_library",
53+
"java_gapic_test",
5454
)
5555

5656
java_proto_library(
@@ -66,11 +66,11 @@ java_grpc_library(
6666

6767
java_gapic_library(
6868
name = "admob_java_gapic",
69-
src = ":admob_proto_with_info",
69+
srcs = [
70+
":admob_proto_with_info"
71+
],
7072
gapic_yaml = "admob_gapic.yaml",
71-
grpc_service_config = None,
72-
package = "google.ads.admob.v1",
73-
service_yaml = "//google/ads/admob:admob_v1.yaml",
73+
grpc_service_config = "//google/ads/admob:admob_grpc_service_config.json",
7474
test_deps = [
7575
":admob_java_grpc",
7676
],
@@ -150,51 +150,30 @@ go_gapic_assembly_pkg(
150150

151151
##############################################################################
152152
# Python
153-
# DO NOT OVERRIDE with autogenerated rules if NOT migrated to Python Microgen
154153
##############################################################################
155154
load(
156155
"@com_google_googleapis_imports//:imports.bzl",
157-
"moved_proto_library",
158156
"py_grpc_library",
159157
"py_proto_library",
160-
py_gapic_assembly_pkg = "py_gapic_assembly_pkg_legacy",
161-
py_gapic_library = "py_gapic_library_legacy",
162-
)
163-
164-
moved_proto_library(
165-
name = "admob_moved_proto",
166-
srcs = [":admob_proto"],
167-
deps = [
168-
"//google/api:annotations_proto",
169-
"//google/api:client_proto",
170-
"//google/api:field_behavior_proto",
171-
"//google/api:resource_proto",
172-
"//google/type:date_proto",
173-
],
158+
"py_gapic_assembly_pkg",
159+
"py_gapic_library",
174160
)
175161

176162
py_proto_library(
177163
name = "admob_py_proto",
178-
plugin = "@protoc_docs_plugin//:docs_plugin",
179-
deps = [":admob_moved_proto"],
164+
deps = [":admob_proto"],
180165
)
181166

182167
py_grpc_library(
183168
name = "admob_py_grpc",
184-
srcs = [":admob_moved_proto"],
169+
srcs = [":admob_proto"],
185170
deps = [":admob_py_proto"],
186171
)
187172

188173
py_gapic_library(
189174
name = "admob_py_gapic",
190-
src = ":admob_proto_with_info",
191-
gapic_yaml = "admob_gapic.yaml",
192-
grpc_service_config = None,
193-
package = "google.ads.admob.v1",
194-
service_yaml = "//google/ads/admob:admob_v1.yaml",
195-
deps = [
196-
":admob_py_grpc",
197-
":admob_py_proto",
175+
srcs = [
176+
":admob_proto_with_info"
198177
],
199178
)
200179

0 commit comments

Comments
 (0)