Skip to content

Commit a95a55f

Browse files
Google APIscopybara-github
authored andcommitted
feat: add env to ContainerSpec in aiplatform v1beta1 custom_job.proto
PiperOrigin-RevId: 453732998
1 parent b37008b commit a95a55f

5 files changed

Lines changed: 33 additions & 1 deletion

File tree

google/cloud/aiplatform/v1beta1/BUILD.bazel

Lines changed: 19 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -118,6 +118,8 @@ proto_library_with_info(
118118
deps = [
119119
":aiplatform_proto",
120120
"//google/cloud:common_resources_proto",
121+
"//google/cloud/location:location_proto",
122+
"//google/iam/v1:iam_policy_proto",
121123
] + _PROTO_SUBPACKAGE_DEPS,
122124
)
123125

@@ -161,13 +163,19 @@ java_grpc_library(
161163
java_gapic_library(
162164
name = "aiplatform_java_gapic",
163165
srcs = [":aiplatform_proto_with_info"],
166+
gapic_yaml = None,
164167
grpc_service_config = "aiplatform_grpc_service_config.json",
168+
service_yaml = "aiplatform_v1beta1.yaml",
165169
test_deps = [
166170
":aiplatform_java_grpc",
171+
"//google/cloud/location:location_java_grpc",
172+
"//google/iam/v1:iam_java_grpc",
167173
] + _JAVA_GRPC_SUBPACKAGE_DEPS,
168174
deps = [
169175
":aiplatform_java_proto",
170176
"//google/api:api_java_proto",
177+
"//google/cloud/location:location_java_proto",
178+
"//google/iam/v1:iam_java_proto",
171179
] + _JAVA_PROTO_SUBPACKAGE_DEPS,
172180
)
173181

@@ -176,12 +184,18 @@ java_gapic_test(
176184
test_classes = [
177185
"com.google.cloud.aiplatform.v1beta1.DatasetServiceClientTest",
178186
"com.google.cloud.aiplatform.v1beta1.EndpointServiceClientTest",
187+
"com.google.cloud.aiplatform.v1beta1.FeaturestoreOnlineServingServiceClientTest",
188+
"com.google.cloud.aiplatform.v1beta1.FeaturestoreServiceClientTest",
189+
"com.google.cloud.aiplatform.v1beta1.IndexEndpointServiceClientTest",
190+
"com.google.cloud.aiplatform.v1beta1.IndexServiceClientTest",
179191
"com.google.cloud.aiplatform.v1beta1.JobServiceClientTest",
192+
"com.google.cloud.aiplatform.v1beta1.MetadataServiceClientTest",
180193
"com.google.cloud.aiplatform.v1beta1.MigrationServiceClientTest",
181194
"com.google.cloud.aiplatform.v1beta1.ModelServiceClientTest",
182195
"com.google.cloud.aiplatform.v1beta1.PipelineServiceClientTest",
183196
"com.google.cloud.aiplatform.v1beta1.PredictionServiceClientTest",
184197
"com.google.cloud.aiplatform.v1beta1.SpecialistPoolServiceClientTest",
198+
"com.google.cloud.aiplatform.v1beta1.TensorboardServiceClientTest",
185199
"com.google.cloud.aiplatform.v1beta1.VizierServiceClientTest",
186200
],
187201
runtime_deps = [":aiplatform_java_gapic_test"],
@@ -233,6 +247,8 @@ go_gapic_library(
233247
deps = [
234248
":aiplatform_go_proto",
235249
"//google/api:httpbody_go_proto",
250+
"//google/cloud/location:location_go_proto",
251+
"//google/iam/v1:iam_go_proto",
236252
"//google/longrunning:longrunning_go_proto",
237253
"@com_google_cloud_go//longrunning:go_default_library",
238254
"@com_google_cloud_go//longrunning/autogen:go_default_library",
@@ -279,6 +295,7 @@ py_gapic_library(
279295
name = "aiplatform_py_gapic",
280296
srcs = [":aiplatform_proto"],
281297
grpc_service_config = "aiplatform_grpc_service_config.json",
298+
service_yaml = "aiplatform_v1beta1.yaml",
282299
)
283300

284301
# Open Source Packages
@@ -434,6 +451,7 @@ csharp_grpc_library(
434451
# srcs = [":aiplatform_proto_with_info"],
435452
# common_resources_config = "@gax_dotnet//:Google.Api.Gax/ResourceNames/CommonResourcesConfig.json",
436453
# grpc_service_config = "aiplatform_grpc_service_config.json",
454+
# service_yaml = "aiplatform_v1beta1.yaml",
437455
# deps = [
438456
# ":aiplatform_csharp_grpc",
439457
# ":aiplatform_csharp_proto",
@@ -451,6 +469,7 @@ csharp_grpc_library(
451469
# )
452470
################################
453471

472+
454473
##############################################################################
455474
# C++
456475
##############################################################################

google/cloud/aiplatform/v1beta1/aiplatform_v1beta1.yaml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,9 @@ apis:
1919
- name: google.cloud.aiplatform.v1beta1.SpecialistPoolService
2020
- name: google.cloud.aiplatform.v1beta1.TensorboardService
2121
- name: google.cloud.aiplatform.v1beta1.VizierService
22+
- name: google.cloud.location.Locations
23+
- name: google.iam.v1.IAMPolicy
24+
- name: google.longrunning.Operations
2225

2326
types:
2427
- name: google.cloud.aiplatform.v1beta1.BatchCreateFeaturesOperationMetadata

google/cloud/aiplatform/v1beta1/custom_job.proto

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@ package google.cloud.aiplatform.v1beta1;
1919
import "google/api/field_behavior.proto";
2020
import "google/api/resource.proto";
2121
import "google/cloud/aiplatform/v1beta1/encryption_spec.proto";
22+
import "google/cloud/aiplatform/v1beta1/env_var.proto";
2223
import "google/cloud/aiplatform/v1beta1/io.proto";
2324
import "google/cloud/aiplatform/v1beta1/job_state.proto";
2425
import "google/cloud/aiplatform/v1beta1/machine_resources.proto";
@@ -232,6 +233,10 @@ message ContainerSpec {
232233

233234
// The arguments to be passed when starting the container.
234235
repeated string args = 3;
236+
237+
// Environment variables to be passed to the container.
238+
// Maximum limit is 100.
239+
repeated EnvVar env = 4;
235240
}
236241

237242
// The spec of a Python packaged code.
@@ -254,6 +259,10 @@ message PythonPackageSpec {
254259

255260
// Command line arguments to be passed to the Python task.
256261
repeated string args = 4;
262+
263+
// Environment variables to be passed to the python module.
264+
// Maximum limit is 100.
265+
repeated EnvVar env = 5;
257266
}
258267

259268
// All parameters related to queuing and scheduling of custom jobs.

google/cloud/aiplatform/v1beta1/featurestore_service.proto

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -418,6 +418,7 @@ message UpdateFeaturestoreRequest {
418418
//
419419
// * `labels`
420420
// * `online_serving_config.fixed_node_count`
421+
// * `online_serving_config.scaling`
421422
google.protobuf.FieldMask update_mask = 2;
422423
}
423424

google/cloud/aiplatform/v1beta1/model_deployment_monitoring_job.proto

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -270,7 +270,7 @@ message ModelDeploymentMonitoringScheduleConfig {
270270
// The time window of the prediction data being included in each prediction
271271
// dataset. This window specifies how long the data should be collected from
272272
// historical model results for each run. If not set,
273-
// [ModelDeploymentMonitoringScheduleConfig.monitor_interval][google.cloud.aiplatform.v1.ModelDeploymentMonitoringScheduleConfig.monitor_interval] will be used.
273+
// [ModelDeploymentMonitoringScheduleConfig.monitor_interval][google.cloud.aiplatform.v1beta1.ModelDeploymentMonitoringScheduleConfig.monitor_interval] will be used.
274274
// e.g. If currently the cutoff time is 2022-01-08 14:30:00 and the
275275
// monitor_window is set to be 3600, then data from 2022-01-08 13:30:00
276276
// to 2022-01-08 14:30:00 will be retrieved and aggregated to calculate the

0 commit comments

Comments
 (0)