Skip to content

Commit a2223b1

Browse files
Google APIscopybara-github
Google APIs
authored and
copybara-github
committed
feat: Enable gpu driver version field on v1
docs: Mark `order_by` field in `ListTasksRequest` as not implemented. docs: Improve url examples in comments PiperOrigin-RevId: 550631094
1 parent ff73e5d commit a2223b1

2 files changed

Lines changed: 46 additions & 24 deletions

File tree

‎google/cloud/batch/v1alpha/batch.proto‎

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -177,9 +177,9 @@ message ListJobsRequest {
177177
// List filter.
178178
string filter = 4;
179179

180-
// Sort results. Supported are "name", "name desc", "create_time",
181-
// "create_time desc", and "".
182-
string order_by = 5;
180+
// Optional. Sort results. Supported are "name", "name desc", "create_time",
181+
// and "create_time desc".
182+
string order_by = 5 [(google.api.field_behavior) = OPTIONAL];
183183

184184
// Page size.
185185
int32 page_size = 2;
@@ -215,8 +215,7 @@ message ListTasksRequest {
215215
// State=RUNNING
216216
string filter = 2;
217217

218-
// Sort results. Supported are "name", "name desc", "create_time",
219-
// "create_time desc", and "".
218+
// Not implemented.
220219
string order_by = 5;
221220

222221
// Page size.

‎google/cloud/batch/v1alpha/job.proto‎

Lines changed: 42 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -313,21 +313,24 @@ message AllocationPolicy {
313313
message Disk {
314314
// A data source from which a PD will be created.
315315
oneof data_source {
316-
// Name of a public or custom image used as the data source.
316+
// Name of an image used as the data source.
317317
// For example, the following are all valid URLs:
318318
//
319319
// * Specify the image by its family name:
320-
// projects/{project}/global/images/family/{image_family}
320+
// <pre><code>projects/<var
321+
// class="apiparam">project</var>/global/images/family/<var
322+
// class="apiparam">image_family</var></code></pre>
321323
// * Specify the image version:
322-
// projects/{project}/global/images/{image_version}
323-
//
324+
// <pre>projects/<var
325+
// class="apiparam">project</var>/global/images/<var
326+
// class="apiparam">image_version</var></code></pre>
324327
// You can also use Batch customized image in short names.
325328
// The following image values are supported for a boot disk:
326329
//
327-
// * "batch-debian": use Batch Debian images.
328-
// * "batch-centos": use Batch CentOS images.
329-
// * "batch-cos": use Batch Container-Optimized images.
330-
// * "batch-hpc-centos": use Batch HPC CentOS images.
330+
// * `batch-debian`: use Batch Debian images.
331+
// * `batch-centos`: use Batch CentOS images.
332+
// * `batch-cos`: use Batch Container-Optimized images.
333+
// * `batch-hpc-centos`: use Batch HPC CentOS images.
331334
string image = 4;
332335

333336
// Name of a snapshot used as the data source.
@@ -388,10 +391,14 @@ message AllocationPolicy {
388391
// Deprecated: please use instances[0].install_gpu_drivers instead.
389392
bool install_gpu_drivers = 3 [deprecated = true];
390393

391-
// The accelerator driver version that will be installed for this type.
394+
// Optional. The NVIDIA GPU driver version that should be installed for this
395+
// type.
392396
//
393-
// Not yet implemented.
394-
string driver_version = 4;
397+
// You can define the specific driver version such as "470.103.01",
398+
// following the driver version requirements in
399+
// https://cloud.google.com/compute/docs/gpus/install-drivers-gpu#minimum-driver.
400+
// Batch will install the specific accelerator driver if qualified.
401+
string driver_version = 4 [(google.api.field_behavior) = OPTIONAL];
395402
}
396403

397404
// InstancePolicy describes an instance type and resources attached to each VM
@@ -444,6 +451,12 @@ message AllocationPolicy {
444451
// third party location and install them for GPUs specified in
445452
// policy.accelerators or instance_template on their behalf. Default is
446453
// false.
454+
//
455+
// For Container-Optimized Image cases, Batch will install the
456+
// accelerator driver following milestones of
457+
// https://cloud.google.com/container-optimized-os/docs/release-notes. For
458+
// non Container-Optimized Image cases, following
459+
// https://github.com/GoogleCloudPlatform/compute-gpu-installation/blob/main/linux/install_gpu_driver.py.
447460
bool install_gpu_drivers = 3;
448461
}
449462

@@ -453,20 +466,30 @@ message AllocationPolicy {
453466
// You can specify the network as a full or partial URL.
454467
//
455468
// For example, the following are all valid URLs:
456-
//
457-
// * https://www.googleapis.com/compute/v1/projects/{project}/global/networks/{network}
458-
// * projects/{project}/global/networks/{network}
459-
// * global/networks/{network}
469+
// <pre><code>https://www.googleapis.com/compute/v1/projects/<var
470+
// class="apiparam">project</var>/global/networks/<var
471+
// class="apiparam">network</var></code></pre>
472+
// <pre><code>projects/<var
473+
// class="apiparam">project</var>/global/networks/<var
474+
// class="apiparam">network</var></code></pre>
475+
// <pre><code>global/networks/<var
476+
// class="apiparam">network</var></code></pre>
460477
string network = 1;
461478

462479
// The URL of an existing subnetwork resource in the network.
463480
// You can specify the subnetwork as a full or partial URL.
464481
//
465482
// For example, the following are all valid URLs:
466-
//
467-
// * https://www.googleapis.com/compute/v1/projects/{project}/regions/{region}/subnetworks/{subnetwork}
468-
// * projects/{project}/regions/{region}/subnetworks/{subnetwork}
469-
// * regions/{region}/subnetworks/{subnetwork}
483+
// <pre><code>https://www.googleapis.com/compute/v1/projects/<var
484+
// class="apiparam">project</var>/regions/<var
485+
// class="apiparam">region</var>/subnetworks/<var
486+
// class="apiparam">subnetwork</var></code></pre>
487+
// <pre><code>projects/<var class="apiparam">project</var>/regions/<var
488+
// class="apiparam">region</var>/subnetworks/<var
489+
// class="apiparam">subnetwork</var></code></pre>
490+
// <pre><code>regions/<var
491+
// class="apiparam">region</var>/subnetworks/<var
492+
// class="apiparam">subnetwork</var></code></pre>
470493
string subnetwork = 2;
471494

472495
// Default is false (with an external IP address). Required if

0 commit comments

Comments
 (0)