Skip to content

Commit 9f82a84

Browse files
Google APIscopybara-github
authored andcommitted
fix!: fix datacatalog resource name config
PiperOrigin-RevId: 464572702
1 parent 75905af commit 9f82a84

4 files changed

Lines changed: 14 additions & 4 deletions

File tree

google/cloud/datacatalog/v1/BUILD.bazel

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -89,6 +89,7 @@ java_gapic_library(
8989
":datacatalog_java_grpc",
9090
"//google/iam/v1:iam_java_grpc",
9191
],
92+
transport = "grpc+rest",
9293
deps = [
9394
":datacatalog_java_proto",
9495
"//google/iam/v1:iam_java_proto",
@@ -98,8 +99,11 @@ java_gapic_library(
9899
java_gapic_test(
99100
name = "datacatalog_java_gapic_test_suite",
100101
test_classes = [
102+
"com.google.cloud.datacatalog.v1.DataCatalogClientHttpJsonTest",
101103
"com.google.cloud.datacatalog.v1.DataCatalogClientTest",
104+
"com.google.cloud.datacatalog.v1.PolicyTagManagerClientHttpJsonTest",
102105
"com.google.cloud.datacatalog.v1.PolicyTagManagerClientTest",
106+
"com.google.cloud.datacatalog.v1.PolicyTagManagerSerializationClientHttpJsonTest",
103107
"com.google.cloud.datacatalog.v1.PolicyTagManagerSerializationClientTest",
104108
],
105109
runtime_deps = [":datacatalog_java_gapic_test"],
@@ -146,6 +150,7 @@ go_gapic_library(
146150
importpath = "cloud.google.com/go/datacatalog/apiv1;datacatalog",
147151
metadata = True,
148152
service_yaml = "datacatalog_v1.yaml",
153+
transport = "grpc+rest",
149154
deps = [
150155
":datacatalog_go_proto",
151156
"//google/iam/v1:iam_go_proto",

google/cloud/datacatalog/v1/datacatalog.proto

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -755,7 +755,7 @@ message ListEntryGroupsRequest {
755755
string parent = 1 [
756756
(google.api.field_behavior) = REQUIRED,
757757
(google.api.resource_reference) = {
758-
type: "datacatalog.googleapis.com/EntryGroup"
758+
child_type: "datacatalog.googleapis.com/EntryGroup"
759759
}
760760
];
761761

@@ -1378,7 +1378,7 @@ message CreateTagRequest {
13781378
string parent = 1 [
13791379
(google.api.field_behavior) = REQUIRED,
13801380
(google.api.resource_reference) = {
1381-
type: "datacatalog.googleapis.com/Tag"
1381+
child_type: "datacatalog.googleapis.com/Tag"
13821382
}
13831383
];
13841384

google/cloud/datacatalog/v1beta1/BUILD.bazel

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -75,6 +75,7 @@ java_gapic_library(
7575
":datacatalog_java_grpc",
7676
"//google/iam/v1:iam_java_grpc",
7777
],
78+
transport = "grpc+rest",
7879
deps = [
7980
":datacatalog_java_proto",
8081
"//google/iam/v1:iam_java_proto",
@@ -85,8 +86,11 @@ java_gapic_test(
8586
name = "datacatalog_java_gapic_test_suite",
8687
test_classes = [
8788
"com.google.cloud.datacatalog.v1beta1.DataCatalogClientTest",
89+
"com.google.cloud.datacatalog.v1beta1.DataCatalogClientHttpJsonTest",
8890
"com.google.cloud.datacatalog.v1beta1.PolicyTagManagerClientTest",
91+
"com.google.cloud.datacatalog.v1beta1.PolicyTagManagerClientHttpJsonTest",
8992
"com.google.cloud.datacatalog.v1beta1.PolicyTagManagerSerializationClientTest",
93+
"com.google.cloud.datacatalog.v1beta1.PolicyTagManagerSerializationClientHttpJsonTest",
9094
],
9195
runtime_deps = [":datacatalog_java_gapic_test"],
9296
)
@@ -131,6 +135,7 @@ go_gapic_library(
131135
grpc_service_config = "datacatalog_grpc_service_config.json",
132136
importpath = "cloud.google.com/go/datacatalog/apiv1beta1;datacatalog",
133137
service_yaml = "datacatalog_v1beta1.yaml",
138+
transport = "grpc+rest",
134139
deps = [
135140
":datacatalog_go_proto",
136141
"//google/iam/v1:iam_go_proto",

google/cloud/datacatalog/v1beta1/datacatalog.proto

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -595,7 +595,7 @@ message ListEntryGroupsRequest {
595595
string parent = 1 [
596596
(google.api.field_behavior) = REQUIRED,
597597
(google.api.resource_reference) = {
598-
type: "datacatalog.googleapis.com/EntryGroup"
598+
child_type: "datacatalog.googleapis.com/EntryGroup"
599599
}
600600
];
601601

@@ -955,7 +955,7 @@ message CreateTagRequest {
955955
string parent = 1 [
956956
(google.api.field_behavior) = REQUIRED,
957957
(google.api.resource_reference) = {
958-
type: "datacatalog.googleapis.com/Tag"
958+
child_type: "datacatalog.googleapis.com/Tag"
959959
}
960960
];
961961

0 commit comments

Comments
 (0)