Skip to content

Commit 91c2661

Browse files
Google APIscopybara-github
authored andcommitted
fix: correct pattern of unused resource definition, Revision
docs: Comments updated for fields in several different resources PiperOrigin-RevId: 755369798
1 parent 9c2cc3c commit 91c2661

1 file changed

Lines changed: 9 additions & 7 deletions

File tree

google/cloud/deploy/v1/cloud_deploy.proto

Lines changed: 9 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -67,7 +67,7 @@ option (google.api.resource_definition) = {
6767
};
6868
option (google.api.resource_definition) = {
6969
type: "run.googleapis.com/Revision"
70-
pattern: "projects/{project}/locations/{location}/revisions/{revision}"
70+
pattern: "projects/{project}/locations/{location}/services/{service}/revisions/{revision}"
7171
};
7272

7373
// CloudDeploy service creates and manages Continuous Delivery operations
@@ -695,15 +695,15 @@ message Postdeploy {
695695

696696
// Standard represents the standard deployment strategy.
697697
message Standard {
698-
// Optional. Whether to verify a deployment.
698+
// Optional. Whether to verify a deployment via `skaffold verify`.
699699
bool verify = 1 [(google.api.field_behavior) = OPTIONAL];
700700

701701
// Optional. Configuration for the predeploy job. If this is not configured,
702-
// predeploy job will not be present.
702+
// the predeploy job will not be present.
703703
Predeploy predeploy = 2 [(google.api.field_behavior) = OPTIONAL];
704704

705705
// Optional. Configuration for the postdeploy job. If this is not configured,
706-
// postdeploy job will not be present.
706+
// the postdeploy job will not be present.
707707
Postdeploy postdeploy = 3 [(google.api.field_behavior) = OPTIONAL];
708708
}
709709

@@ -737,7 +737,8 @@ message CanaryDeployment {
737737
// n is 0 <= n <= 100.
738738
repeated int32 percentages = 1 [(google.api.field_behavior) = REQUIRED];
739739

740-
// Optional. Whether to run verify tests after each percentage deployment.
740+
// Optional. Whether to run verify tests after each percentage deployment via
741+
// `skaffold verify`.
741742
bool verify = 2 [(google.api.field_behavior) = OPTIONAL];
742743

743744
// Optional. Configuration for the predeploy job of the first phase. If this
@@ -770,7 +771,8 @@ message CustomCanaryDeployment {
770771
// `DeliveryPipeline` stage.
771772
repeated string profiles = 3 [(google.api.field_behavior) = OPTIONAL];
772773

773-
// Optional. Whether to run verify tests after the deployment.
774+
// Optional. Whether to run verify tests after the deployment via `skaffold
775+
// verify`.
774776
bool verify = 4 [(google.api.field_behavior) = OPTIONAL];
775777

776778
// Optional. Configuration for the predeploy job of this phase. If this is
@@ -2089,7 +2091,7 @@ message DeployPolicy {
20892091
// Required. Rules to apply. At least one rule must be present.
20902092
repeated PolicyRule rules = 10 [(google.api.field_behavior) = REQUIRED];
20912093

2092-
// The weak etag of the `Automation` resource.
2094+
// The weak etag of the `DeployPolicy` resource.
20932095
// This checksum is computed by the server based on the value of other
20942096
// fields, and may be sent on update and delete requests to ensure the
20952097
// client has an up-to-date value before proceeding.

0 commit comments

Comments
 (0)