Skip to content

Commit 8c9639a

Browse files
Google APIscopybara-github
authored andcommitted
docs: updated comment for customer_managed_encryption in message .google.cloud.secretmanager.v1.Secret
docs: updated comment for `scheduled_destroy_time` in message `.google.cloud.secretmanager.v1.SecretVersion` docs: updated comment for `customer_managed_encryption` in message `.google.cloud.secretmanager.v1.SecretVersion` docs: updated comment for `Replication` docs: updated comment for `name` in message `.google.cloud.secretmanager.v1.Topic` PiperOrigin-RevId: 715945530
1 parent 399e86e commit 8c9639a

2 files changed

Lines changed: 12 additions & 14 deletions

File tree

google/cloud/secretmanager/v1/resources.proto

Lines changed: 12 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,6 @@ import "google/api/resource.proto";
2121
import "google/protobuf/duration.proto";
2222
import "google/protobuf/timestamp.proto";
2323

24-
option cc_enable_arenas = true;
2524
option csharp_namespace = "Google.Cloud.SecretManager.V1";
2625
option go_package = "cloud.google.com/go/secretmanager/apiv1/secretmanagerpb;secretmanagerpb";
2726
option java_multiple_files = true;
@@ -151,8 +150,8 @@ message Secret {
151150
google.protobuf.Duration version_destroy_ttl = 14
152151
[(google.api.field_behavior) = OPTIONAL];
153152

154-
// Optional. The customer-managed encryption configuration of the Regionalised
155-
// Secrets. If no configuration is provided, Google-managed default encryption
153+
// Optional. The customer-managed encryption configuration of the regionalized
154+
// secrets. If no configuration is provided, Google-managed default encryption
156155
// is used.
157156
//
158157
// Updates to the [Secret][google.cloud.secretmanager.v1.Secret] encryption
@@ -244,16 +243,15 @@ message SecretVersion {
244243
// Optional. Output only. Scheduled destroy time for secret version.
245244
// This is a part of the Delayed secret version destroy feature. For a
246245
// Secret with a valid version destroy TTL, when a secert version is
247-
// destroyed, the version is moved to disabled state and it is scheduled for
248-
// destruction. The version is destroyed only after the
249-
// `scheduled_destroy_time`.
246+
// destroyed, version is moved to disabled state and it is scheduled for
247+
// destruction Version is destroyed only after the scheduled_destroy_time.
250248
google.protobuf.Timestamp scheduled_destroy_time = 8
251249
[(google.api.field_behavior) = OUTPUT_ONLY];
252250

253251
// Output only. The customer-managed encryption status of the
254252
// [SecretVersion][google.cloud.secretmanager.v1.SecretVersion]. Only
255253
// populated if customer-managed encryption is used and
256-
// [Secret][google.cloud.secretmanager.v1.Secret] is a Regionalised Secret.
254+
// [Secret][google.cloud.secretmanager.v1.Secret] is a regionalized secret.
257255
CustomerManagedEncryptionStatus customer_managed_encryption = 9
258256
[(google.api.field_behavior) = OUTPUT_ONLY];
259257
}
@@ -279,7 +277,8 @@ message Replication {
279277

280278
// A replication policy that replicates the
281279
// [Secret][google.cloud.secretmanager.v1.Secret] payload into the locations
282-
// specified in [Secret.replication.user_managed.replicas][]
280+
// specified in
281+
// [Replication.UserManaged.replicas][google.cloud.secretmanager.v1.Replication.UserManaged.replicas]
283282
message UserManaged {
284283
// Represents a Replica for this
285284
// [Secret][google.cloud.secretmanager.v1.Secret].
@@ -422,12 +421,12 @@ message Topic {
422421
pattern: "projects/{project}/topics/{topic}"
423422
};
424423

425-
// Required. The resource name of the Pub/Sub topic that will be published to,
426-
// in the following format: `projects/*/topics/*`. For publication to succeed,
427-
// the Secret Manager service agent must have the `pubsub.topic.publish`
428-
// permission on the topic. The Pub/Sub Publisher role
424+
// Identifier. The resource name of the Pub/Sub topic that will be published
425+
// to, in the following format: `projects/*/topics/*`. For publication to
426+
// succeed, the Secret Manager service agent must have the
427+
// `pubsub.topic.publish` permission on the topic. The Pub/Sub Publisher role
429428
// (`roles/pubsub.publisher`) includes this permission.
430-
string name = 1 [(google.api.field_behavior) = REQUIRED];
429+
string name = 1 [(google.api.field_behavior) = IDENTIFIER];
431430
}
432431

433432
// The rotation time and period for a

google/cloud/secretmanager/v1/service.proto

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,6 @@ import "google/iam/v1/policy.proto";
2626
import "google/protobuf/empty.proto";
2727
import "google/protobuf/field_mask.proto";
2828

29-
option cc_enable_arenas = true;
3029
option csharp_namespace = "Google.Cloud.SecretManager.V1";
3130
option go_package = "cloud.google.com/go/secretmanager/apiv1/secretmanagerpb;secretmanagerpb";
3231
option java_multiple_files = true;

0 commit comments

Comments
 (0)