Skip to content

Commit 85d120d

Browse files
Google APIscopybara-github
authored andcommitted
fix: Changed field behavior for an existing field per_unit_storage_throughput. It is now required
docs: expand on and update various comments PiperOrigin-RevId: 766812120
1 parent 9953dde commit 85d120d

3 files changed

Lines changed: 30 additions & 22 deletions

File tree

google/cloud/lustre/v1/BUILD.bazel

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -305,9 +305,7 @@ ruby_grpc_library(
305305
ruby_cloud_gapic_library(
306306
name = "lustre_ruby_gapic",
307307
srcs = [":lustre_proto_with_info"],
308-
extra_protoc_parameters = [
309-
"ruby-cloud-gem-name=google-cloud-lustre-v1",
310-
],
308+
extra_protoc_parameters = ["ruby-cloud-gem-name=google-cloud-lustre-v1"],
311309
grpc_service_config = "lustre_v1_grpc_service_config.json",
312310
rest_numeric_enums = True,
313311
service_yaml = "lustre_v1.yaml",
@@ -342,7 +340,6 @@ load(
342340

343341
csharp_proto_library(
344342
name = "lustre_csharp_proto",
345-
extra_opts = [],
346343
deps = [":lustre_proto"],
347344
)
348345

google/cloud/lustre/v1/instance.proto

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -72,7 +72,7 @@ message Instance {
7272
];
7373

7474
// Required. The storage capacity of the instance in gibibytes (GiB). Allowed
75-
// values are from `18000` to `936000`, in increments of 9000.
75+
// values are from `18000` to `954000`, in increments of 9000.
7676
int64 capacity_gib = 2 [(google.api.field_behavior) = REQUIRED];
7777

7878
// Required. Immutable. The full name of the VPC network to which the instance
@@ -105,11 +105,10 @@ message Instance {
105105
// Optional. Labels as key value pairs.
106106
map<string, string> labels = 9 [(google.api.field_behavior) = OPTIONAL];
107107

108-
// Optional. The throughput of the instance in MB/s/TiB.
109-
// Valid values are 250, 500, 1000.
110-
// Default value is 1000.
108+
// Required. The throughput of the instance in MB/s/TiB.
109+
// Valid values are 125, 250, 500, 1000.
111110
int64 per_unit_storage_throughput = 11
112-
[(google.api.field_behavior) = OPTIONAL];
111+
[(google.api.field_behavior) = REQUIRED];
113112

114113
// Optional. Indicates whether you want to enable support for GKE clients. By
115114
// default, GKE clients are not supported.

google/cloud/lustre/v1/transfer.proto

Lines changed: 25 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -42,9 +42,11 @@ enum TransferType {
4242
// Message for importing data to Lustre.
4343
message ImportDataRequest {
4444
// A Cloud Storage URI of a folder to import file data from, in the
45-
// form of `gs://<bucket_name>/<path_inside_bucket>`
45+
// form of `gs://<bucket_name>/<path_inside_bucket>/`.
4646
oneof source {
4747
// The Cloud Storage source bucket and, optionally, path inside the bucket.
48+
// If a path inside the bucket is specified, it must end with a forward
49+
// slash (`/`).
4850
GcsPath gcs_path = 2;
4951
}
5052

@@ -54,7 +56,8 @@ message ImportDataRequest {
5456
LustrePath lustre_path = 3;
5557
}
5658

57-
// Required. Name of the resource.
59+
// Required. The name of the Managed Lustre instance in the format
60+
// `projects/{project}/locations/{location}/instances/{instance}`.
5861
string name = 1 [
5962
(google.api.field_behavior) = REQUIRED,
6063
(google.api.resource_reference) = { type: "lustre.googleapis.com/Instance" }
@@ -67,7 +70,7 @@ message ImportDataRequest {
6770
];
6871

6972
// Optional. User-specified service account used to perform the transfer.
70-
// If unspecified, the default Lustre P4 service account will be used.
73+
// If unspecified, the default Managed Lustre service agent will be used.
7174
string service_account = 5 [
7275
(google.api.field_behavior) = OPTIONAL,
7376
(google.api.resource_reference) = {
@@ -76,21 +79,26 @@ message ImportDataRequest {
7679
];
7780
}
7881

79-
// Message for exporting data from Lustre.
82+
// Export data from Managed Lustre to a Cloud Storage bucket.
8083
message ExportDataRequest {
8184
// The source of the data transfer.
8285
oneof source {
83-
// Lustre path source.
86+
// The root directory path to the Managed Lustre file system. Must start
87+
// with `/`. Default is `/`.
8488
LustrePath lustre_path = 2;
8589
}
8690

8791
// The destination of the data transfer.
8892
oneof destination {
89-
// Cloud Storage destination.
93+
// The URI to a Cloud Storage bucket, or a path within a bucket, using
94+
// the format `gs://<bucket_name>/<optional_path_inside_bucket>/`. If a
95+
// path inside the bucket is specified, it must end with a forward slash
96+
// (`/`).
9097
GcsPath gcs_path = 3;
9198
}
9299

93-
// Required. Name of the resource.
100+
// Required. The name of the Managed Lustre instance in the format
101+
// `projects/{project}/locations/{location}/instances/{instance}`.
94102
string name = 1 [
95103
(google.api.field_behavior) = REQUIRED,
96104
(google.api.resource_reference) = { type: "lustre.googleapis.com/Instance" }
@@ -183,17 +191,21 @@ message ImportDataMetadata {
183191
string api_version = 8 [(google.api.field_behavior) = OUTPUT_ONLY];
184192
}
185193

186-
// Cloud Storage as the source of a data transfer.
194+
// Specifies a Cloud Storage bucket and, optionally, a path inside the bucket.
187195
message GcsPath {
188-
// Required. URI to a Cloud Storage path in the format:
189-
// `gs://<bucket_name>`.
196+
// Required. The URI to a Cloud Storage bucket, or a path within a bucket,
197+
// using the format `gs://<bucket_name>/<optional_path_inside_bucket>/`. If a
198+
// path inside the bucket is specified, it must end with a forward slash
199+
// (`/`).
190200
string uri = 1 [(google.api.field_behavior) = REQUIRED];
191201
}
192202

193-
// LustrePath represents a path in the Lustre file system.
203+
// The root directory path to the Lustre file system.
194204
message LustrePath {
195-
// Optional. Root directory path to the Managed Lustre file system, starting
196-
// with `/`. Defaults to `/` if unset.
205+
// Optional. The root directory path to the Managed Lustre file system. Must
206+
// start with
207+
// `/`. Default is `/`. If you're importing data into Managed Lustre, any
208+
// path other than the default must already exist on the file system.
197209
string path = 1 [(google.api.field_behavior) = OPTIONAL];
198210
}
199211

0 commit comments

Comments
 (0)