fix!: Fixing PHP, Ruby and C# package names for the CloudDMS API. This is a breaking change for the above languages.

Google APIs · copybara-github · commit 6c96d191b317 · 2021-05-10T23:27:55.000-07:00
Committer: @jmpfar PiperOrigin-RevId: 373087373
diff --git a/google/cloud/clouddms/logging/v1/clouddms_platform_logs.proto b/google/cloud/clouddms/logging/v1/clouddms_platform_logs.proto
@@ -21,10 +21,13 @@ import "google/protobuf/duration.proto";
 import "google/protobuf/timestamp.proto";
 import "google/rpc/status.proto";
 
+option csharp_namespace = "Google.Cloud.CloudDms.Logging.V1";
 option go_package = "google.golang.org/genproto/googleapis/cloud/clouddms/logging/v1;logging";
 option java_multiple_files = true;
 option java_outer_classname = "ClouddmsPlatformLogsProto";
 option java_package = "com.google.cloud.clouddms.logging.v1";
+option php_namespace = "Google\\Cloud\\CloudDms\\Logging\\V1";
+option ruby_package = "Google::Cloud::CloudDMS::Logging::V1";
 
 // The database engines.
 enum DatabaseEngine {
diff --git a/google/cloud/clouddms/v1/clouddms.proto b/google/cloud/clouddms/v1/clouddms.proto
@@ -25,10 +25,13 @@ import "google/longrunning/operations.proto";
 import "google/protobuf/field_mask.proto";
 import "google/protobuf/timestamp.proto";
 
+option csharp_namespace = "Google.Cloud.CloudDms.V1";
 option go_package = "google.golang.org/genproto/googleapis/cloud/clouddms/v1;clouddms";
 option java_multiple_files = true;
 option java_outer_classname = "ClouddmsProto";
 option java_package = "com.google.cloud.clouddms.v1";
+option php_namespace = "Google\\Cloud\\CloudDms\\V1";
+option ruby_package = "Google::Cloud::CloudDMS::V1";
 
 // Database Migration service
 service DataMigrationService {
diff --git a/google/cloud/clouddms/v1/clouddms_resources.proto b/google/cloud/clouddms/v1/clouddms_resources.proto
@@ -24,10 +24,13 @@ import "google/protobuf/wrappers.proto";
 import "google/rpc/status.proto";
 import "google/api/annotations.proto";
 
+option csharp_namespace = "Google.Cloud.CloudDms.V1";
 option go_package = "google.golang.org/genproto/googleapis/cloud/clouddms/v1;clouddms";
 option java_multiple_files = true;
 option java_outer_classname = "ClouddmsResourcesProto";
 option java_package = "com.google.cloud.clouddms.v1";
+option php_namespace = "Google\\Cloud\\CloudDms\\V1";
+option ruby_package = "Google::Cloud::CloudDMS::V1";
 
 // SSL configuration information.
 message SslConfig {
@@ -173,7 +176,7 @@ message SqlIpConfig {
 
   // The resource link for the VPC network from which the Cloud SQL instance is
   // accessible for private IP. For example,
-  // `/projects/myProject/global/networks/default`. This setting can
+  // `projects/myProject/global/networks/default`. This setting can
   // be updated, but it cannot be removed after it is set.
   string private_network = 2;
 
diff --git a/google/cloud/clouddms/v1/datamigration_gapic.yaml b/google/cloud/clouddms/v1/datamigration_gapic.yaml
@@ -8,11 +8,11 @@ language_settings:
   go:
     package_name: cloud.google.com/go/clouddms/apiv1
   csharp:
-    package_name: Google.Cloud.Clouddms.V1
+    package_name: Google.Cloud.CloudDms.V1
   ruby:
-    package_name: Google::Cloud::Clouddms::V1
+    package_name: Google::Cloud::CloudDMS::V1
   php:
-    package_name: Google\Cloud\Clouddms\V1
+    package_name: Google\Cloud\CloudDms\V1
   nodejs:
     package_name: clouddms.v1
     domain_layer_location: google-cloud
